https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/131023
I broke this in https://github.com/llvm/llvm-project/commit/f3cd2238383f695c719e7eab6aebec828781ec91, I should have added this to the `SPIRV64` subclass, but I accidentally added it to base `TargetInfo`. >From 8607be8643c6f0a02748031b48a242526c5e9a5a Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" <nick.sar...@intel.com> Date: Wed, 12 Mar 2025 13:27:56 -0700 Subject: [PATCH] [clang][NFCI] Fix getGridValues for unsupported targets Signed-off-by: Sarnie, Nick <nick.sar...@intel.com> --- clang/include/clang/Basic/TargetInfo.h | 1 + clang/lib/Basic/Targets/SPIR.h | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/clang/include/clang/Basic/TargetInfo.h b/clang/include/clang/Basic/TargetInfo.h index d136b459e9cd4..158d0ded96bc4 100644 --- a/clang/include/clang/Basic/TargetInfo.h +++ b/clang/include/clang/Basic/TargetInfo.h @@ -1675,6 +1675,7 @@ class TargetInfo : public TransferrableTargetInfo, // access target-specific GPU grid values that must be consistent between // host RTL (plugin), deviceRTL and clang. virtual const llvm::omp::GV &getGridValue() const { + llvm_unreachable("getGridValue not implemented on this target"); return llvm::omp::SPIRVGridValues; } diff --git a/clang/lib/Basic/Targets/SPIR.h b/clang/lib/Basic/Targets/SPIR.h index 610efa1fe00d9..78505d66d6f2f 100644 --- a/clang/lib/Basic/Targets/SPIR.h +++ b/clang/lib/Basic/Targets/SPIR.h @@ -370,6 +370,10 @@ class LLVM_LIBRARY_VISIBILITY SPIRV64TargetInfo : public BaseSPIRVTargetInfo { void getTargetDefines(const LangOptions &Opts, MacroBuilder &Builder) const override; + + const llvm::omp::GV &getGridValue() const override { + return llvm::omp::SPIRVGridValues; + } }; class LLVM_LIBRARY_VISIBILITY SPIRV64AMDGCNTargetInfo final _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
