github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S 
'([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 
cd043e4fbe6125df4cb4993c625fa5e46194e478 
cb6a620c93b3809742fd067233844221e74dde4f 
llvm/test/Transforms/SROA/scalable-vectors-with-known-vscale.ll 
clang/test/CodeGen/RISCV/attr-riscv-rvv-vector-bits-less-8-call.c 
clang/test/CodeGen/RISCV/attr-riscv-rvv-vector-bits-less-8-cast.c 
clang/test/CodeGen/RISCV/attr-rvv-vector-bits-cast.c 
clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c 
llvm/include/llvm/IR/Attributes.h llvm/include/llvm/IR/DerivedTypes.h 
llvm/lib/IR/AttributeImpl.h llvm/lib/IR/Attributes.cpp 
llvm/lib/Transforms/Scalar/SROA.cpp 
llvm/test/Transforms/SROA/scalable-vectors.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/Transforms/SROA/scalable-vectors-with-known-vscale.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated 
and should only be used in the rare cases where no replacement is possible. For 
example, a load of uninitialized memory yields `undef`. You should use `poison` 
values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. 
If you need an operand with some unimportant value, you can add a new argument 
to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior 
Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/130973
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to