smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
Makes sense to me. Some questions inline, but they may not necessitate changes,
so I'm accepting.
================
Comment at: lib/CMakeLists.txt:166
+ if (NOT LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS)
+ add_link_flags("/usr/lib/libc++abi.dylib
-Wl,-reexported_symbols_list,${CMAKE_CURRENT_SOURCE_DIR}/libc++abi-new-delete.exp")
+ endif()
----------------
Do you need to repeat the `libc++abi.dylib` path? Would it be more appropriate
to append this to `OSX_RE_EXPORT_LINE`?
https://reviews.llvm.org/D31644
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
