https://github.com/HighCommander4 requested changes to this pull request.
Thanks! I tried out the patch with clangd and it seems to be working pretty
well.
A further enhancement that occurs to me is that we could offer these patterns
slightly earlier, e.g. when you're at the beginning of an empty line and invoke
code completion and then type `if` to filter the results, you see the `if
(condition) {statements}` pattern as the first result -- we could have `if
constexpr (condition) {statements}` as another result there already. But that
can be a future enhancement for another time.
The implementation looks pretty good, just have some minor comments.
https://github.com/llvm/llvm-project/pull/124315
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
