Carlos =?utf-8?q?Gálvez?= <carlos.gal...@zenseact.com>, Carlos =?utf-8?q?Gálvez?= <carlos.gal...@zenseact.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/128...@github.com>
HerrCai0907 wrote: > > The current patch is still unstable in my opinion. > > If that is the case that is an even stronger argument to not land it but let > it cook a bit more. > I hope it can be land and then more person can test it in real project instead of testsuites. Because we still have enough time for next official release, it will not compromise robustness. Keeping it here is meaningless unless more people review it. This patch is heading in the right direction and doing the right things, although it still has some shortcomings, such as not being able to support full analysis mode. But I don't think needing more features is not a correct reason to block merging. Here are some of my personal opinions about code structure, I think it's just a personal preference, there's no right or wrong. > I still fail to understand what is the push back from moving the code to the > proper component. If it is a common part, then it definitely needs to move to common parent component. But at this time point, there are no other sub project use it, which means it is not a common part. Considering the potential risks mentioned above, I also don't understand why it "must" move to parent component. Again, I am not against to move, just think both are fine now. https://github.com/llvm/llvm-project/pull/128150 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
