https://github.com/shafik commented:
Thank you for the PR, some after commit review. The bugprone comment should be addressed and if there are more cases we catch that are not covered by existing tests, we should add more tests. The in class member initializers feels like it would be worth doing but I would not insist on it. https://github.com/llvm/llvm-project/pull/129198 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits