VladiKrapp-Arm wrote:

@Zhenhang1213 Might I suggest changes along the lines of 

https://github.com/VladiKrapp-Arm/llvm-project/commit/63e4f10eaefc024e2afc41e5151411a383226a8b

This separates the check for whether the platform allows hardware tls from 
whether it is possible to encode using thumb2. Both these checks should be made 
for auto mode, so we don't automatically select this mode for the user when 
they might have some functions compiled with soft mode. 
@smithp35 : This still isn't exactly the same as what gcc does, because there 
auto mode is enabled if it's armv6k and arm mode. This check could be done here 
as well, but could still cause problems if user compiles as in your example 
with __attribute__((target("thumb"))). 

https://github.com/llvm/llvm-project/pull/130027
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to