[clang-tools-extra] [clang-tidy] detect arithmetic operations within member list initialization in modernize-use-default-member-init check (PR #129370)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 83d2c68fc151ab50e005ecd36edb53a2af89e71c 
60856b908e2b52cc512445d7d31e7fc72cd124cb --extensions cpp -- 
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp 
clang-tools-extra/test/clang-tidy/checkers/modernize/use-default-member-init.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git 
a/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp 
b/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
index a9d9e8b66e..d155207d2a 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
@@ -163,7 +163,7 @@ static bool sameValue(const Expr *E1, const Expr *E2) {
     const auto *BinOp1 = cast<BinaryOperator>(E1);
     const auto *BinOp2 = cast<BinaryOperator>(E2);
     return sameValue(BinOp1->getLHS(), BinOp2->getLHS()) &&
-        sameValue(BinOp1->getRHS(), BinOp2->getRHS());
+           sameValue(BinOp1->getRHS(), BinOp2->getRHS());
   }
   case Stmt::CharacterLiteralClass:
     return cast<CharacterLiteral>(E1)->getValue() ==
@@ -209,11 +209,12 @@ void 
UseDefaultMemberInitCheck::registerMatchers(MatchFinder *Finder) {
                           hasUnaryOperand(floatLiteral())),
             cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(),
             declRefExpr(to(enumConstantDecl())),
-            binaryOperator(
-                hasLHS(anyOf(integerLiteral(), floatLiteral(),
-                             declRefExpr(to(enumConstantDecl())), 
binaryOperator())),
-                hasRHS(anyOf(integerLiteral(), floatLiteral(),
-                             declRefExpr(to(enumConstantDecl())), 
binaryOperator()))));
+            binaryOperator(hasLHS(anyOf(integerLiteral(), floatLiteral(),
+                                        declRefExpr(to(enumConstantDecl())),
+                                        binaryOperator())),
+                           hasRHS(anyOf(integerLiteral(), floatLiteral(),
+                                        declRefExpr(to(enumConstantDecl())),
+                                        binaryOperator()))));
 
   auto Init =
       anyOf(initListExpr(anyOf(allOf(initCountIs(1), hasInit(0, InitBase)),

``````````

</details>


https://github.com/llvm/llvm-project/pull/129370
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits