Bigcheese wrote:

Given that some `#pragma`s also impact Sema things, I think `scope` is a bit 
confusing for what it applies to. I think something like `macro_scope` would be 
a better name.

As for the extension itself, I think it could be useful, but I'm not sure how 
our language extension policy applies here for pragmas. This is kind of a 
general purpose extension and would make the code only usable with Clang, as 
conditionally applying the pragma would mean the macros still show up and your 
code breaks (otherwise why would you have the pragma in the first place).

This also hides include guards, and I don't think it does anything about 
include skipping, so it may behave as if the include guard was still there.

https://github.com/llvm/llvm-project/pull/121025
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to