================
@@ -448,7 +453,8 @@ class ItaniumCXXABI : public CodeGen::CGCXXABI {
        if (!IsInlined)
          continue;
 
-       StringRef Name = CGM.getMangledName(VtableComponent.getGlobalDecl());
+       StringRef Name =
+           CGM.getMangledName(VtableComponent.getGlobalDecl(false));
----------------
Fznamznon wrote:

> Perhaps it should be a method of VTableContextBase

I liked the idea at first, but `getGlobalDecl` also requires to know Kind and 
FunctionDecl of a particular VTableComponent which makes it require two 
parameters as a method of `VTableContextBase`. If that is ok, I would prefer to 
add the comment with ParamName instead.


https://github.com/llvm/llvm-project/pull/126240
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to