EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus the suggested cleanup.
================
Comment at: include/__libunwind_config.h:15
!defined(__ARM_DWARF_EH__)
#define _LIBUNWIND_ARM_EHABI 1
#endif
----------------
This should have an empty definition to avoid people depending on the value `1`.
================
Comment at: include/__libunwind_config.h:20
# if defined(__i386__)
# define _LIBUNWIND_TARGET_I386 1
# define _LIBUNWIND_CONTEXT_SIZE 8
----------------
This should have an empty definition to avoid people depending on the value `1`.
================
Comment at: src/config.h:35
#if defined(FOR_DYLD)
#define _LIBUNWIND_SUPPORT_COMPACT_UNWIND 1
#else
----------------
This should have an empty definition to avoid people depending on the value `1`.
================
Comment at: src/config.h:52
#if (defined(__APPLE__) && defined(__arm__)) ||
defined(__USING_SJLJ_EXCEPTIONS__)
#define _LIBUNWIND_BUILD_SJLJ_APIS 1
#endif
----------------
This should have an empty definition to avoid people depending on the value `1`.
================
Comment at: src/config.h:56
#if defined(__i386__) || defined(__x86_64__) || defined(__ppc__) ||
defined(__ppc64__)
#define _LIBUNWIND_SUPPORT_FRAME_APIS 1
#endif
----------------
This should have an empty definition to avoid people depending on the value `1`.
================
Comment at: src/config.h:64
(defined(__APPLE__) && defined(__mips__))
#define _LIBUNWIND_BUILD_ZERO_COST_APIS 1
#endif
----------------
This should have an empty definition to avoid people depending on the value `1`.
https://reviews.llvm.org/D31078
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
