https://github.com/erichkeane commented:
Only a quick scroll through here, and @cor3ntin is the right one to review this, but the test coverage for the new diagnostics seems non-existant. And much of the test changes themselves are just changing what looks like they are valid tests. Please ADD tests for your new things, and make it clear what/why you're changing existing tests in this way. https://github.com/llvm/llvm-project/pull/117953 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
