EricWF added a comment.

I really dislike that `__libcpp_clock_monotonic` and `__libcpp_clock_realtime` 
are never declared, and are expected to be magically defined by the external 
threading header.
This makes the configuration seem incorrect and unused.

Also the previous threading support changes were beneficial to libc++ because 
they cleaned up and centralized the threading interface, making it easier to 
port libc++ to different
threading environments. This change has no such benefit.

Why should libc++ upstream this ARM specific configuration need?


https://reviews.llvm.org/D29818



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to