alexfh added inline comments.
================
Comment at: clang-tidy/readability/OperatorsRepresentationCheck.cpp:34
+
+ if (const auto *B = Result.Nodes.getNodeAs<BinaryOperator>("binary")) {
+ switch (B->getOpcode()) {
----------------
aaron.ballman wrote:
> I think this would make more sense lifted into an AST matcher -- there are
> bound to be a *lot* of binary operators, so letting the matcher memoize
> things is likely to give better performance.
Any reasons not to do this on the lexer level?
https://reviews.llvm.org/D31308
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
