JonPsson1 wrote:

Updated per review.

- Wrapping all isel handlings of FP with !useSoftFloat to make sure no custom 
lowerering may ever use an FP reg. I am not really sure this is needed as the 
type-legalizer is run before any lowering, but maybe do it just to be sure.

- Also found out that a simple program involving an FCMP could not be handled, 
so added handling for SELECT_CC. This node is handled per the result VT, so the 
promotion to float of the compare operands never happened. Adding the FPEXT:s 
in lowerSELECT_CC(). The other related nodes are on the other hand lowered 
according to the type of their operands (by SelectionDAGLegalize::LegalizeOp), 
so they get their operands promoted properly. Some new tests for this in 
fp-half-cmp.ll.


https://github.com/llvm/llvm-project/pull/109164
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to