leanil marked 2 inline comments as done.
leanil added inline comments.
================
Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:119
+ DisabledMove = false;
+ for (const auto *OtherCtor : Ctor->getParent()->ctors()) {
+ if (OtherCtor->isCopyConstructor()) {
----------------
This is the most precise way to formulate the warning message I could come up
with.
The condition for excluding either "copy" or "move" from the warning is to find
only disabled instances of the constructor type, and there must be at least
one, otherwise the compiler generated constructor (which is not present in this
enumeration) can be hidden.
Repository:
rL LLVM
https://reviews.llvm.org/D30547
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
