https://github.com/ur4t updated https://github.com/llvm/llvm-project/pull/65451
>From 77d8ba05ccf4f8d6953373d1e4f118ddbe865be9 Mon Sep 17 00:00:00 2001 From: ur4t <46435411+u...@users.noreply.github.com> Date: Thu, 17 Aug 2023 23:21:39 +0800 Subject: [PATCH 1/2] [llvm][CMake] Fix llvm shared library when using ninja multi config --- llvm/tools/llvm-shlib/CMakeLists.txt | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/llvm/tools/llvm-shlib/CMakeLists.txt b/llvm/tools/llvm-shlib/CMakeLists.txt index ede3c5034e045..a5b0cab0f1ce5 100644 --- a/llvm/tools/llvm-shlib/CMakeLists.txt +++ b/llvm/tools/llvm-shlib/CMakeLists.txt @@ -45,10 +45,19 @@ if(LLVM_BUILD_LLVM_DYLIB) if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin") set(LIB_NAMES -Wl,-all_load ${LIB_NAMES}) else() - configure_file( - ${CMAKE_CURRENT_SOURCE_DIR}/simple_version_script.map.in - ${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map) - + if("${CMAKE_CFG_INTDIR}" STREQUAL ".") + configure_file( + ${CMAKE_CURRENT_SOURCE_DIR}/simple_version_script.map.in + ${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map) + else() + foreach(BUILD_MODE ${CMAKE_CONFIGURATION_TYPES}) + # Replace the special string with a per config directory. + string(REPLACE ${CMAKE_CFG_INTDIR} ${BUILD_MODE} PER_CONF_LIBRARY_DIR ${LLVM_LIBRARY_DIR}) + configure_file( + ${CMAKE_CURRENT_SOURCE_DIR}/simple_version_script.map.in + ${PER_CONF_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map) + endforeach() + endif() if(MSVC) target_link_directories(LLVM PRIVATE ${LLVM_LIBRARY_DIR}) foreach(library ${LIB_NAMES}) @@ -156,7 +165,10 @@ if(LLVM_BUILD_LLVM_C_DYLIB AND MSVC) # Need to separate lib names with newlines. string(REPLACE ";" "\n" FILE_CONTENT "${FULL_LIB_NAMES}") - if(NOT "${CMAKE_CFG_INTDIR}" STREQUAL ".") + if("${CMAKE_CFG_INTDIR}" STREQUAL ".") + # Write out the full lib names into file to be read by the python script. + file(WRITE ${LIBSFILE} "${FILE_CONTENT}") + else() foreach(BUILD_MODE ${CMAKE_CONFIGURATION_TYPES}) # Replace the special string with a per config directory. string(REPLACE ${CMAKE_CFG_INTDIR} ${BUILD_MODE} PER_CONF_CONTENT "${FILE_CONTENT}") @@ -166,9 +178,6 @@ if(LLVM_BUILD_LLVM_C_DYLIB AND MSVC) # ${CMAKE_CFG_INTDIR} correctly and select the right one. file(WRITE ${LLVM_BINARY_DIR}/${BUILD_MODE}/libllvm-c.args "${PER_CONF_CONTENT}") endforeach() - else() - # Write out the full lib names into file to be read by the python script. - file(WRITE ${LIBSFILE} "${FILE_CONTENT}") endif() # Generate the exports file dynamically. >From d603987c218e11761dc2d703241a4b1b056ecba7 Mon Sep 17 00:00:00 2001 From: ur4t <46435411+u...@users.noreply.github.com> Date: Mon, 17 Feb 2025 20:10:10 +0800 Subject: [PATCH 2/2] [clang][CMake] Fix clang headers when using ninja multi config --- clang/lib/Headers/CMakeLists.txt | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/clang/lib/Headers/CMakeLists.txt b/clang/lib/Headers/CMakeLists.txt index 43124111b7ba5..a3a505bcb7f88 100644 --- a/clang/lib/Headers/CMakeLists.txt +++ b/clang/lib/Headers/CMakeLists.txt @@ -395,12 +395,25 @@ set(riscv_generated_files) function(copy_header_to_output_dir src_dir file) set(src ${src_dir}/${file}) - set(dst ${output_dir}/${file}) - add_custom_command(OUTPUT ${dst} - DEPENDS ${src} - COMMAND ${CMAKE_COMMAND} -E copy_if_different ${src} ${dst} - COMMENT "Copying clang's ${file}...") - list(APPEND out_files ${dst}) + if("${CMAKE_CFG_INTDIR}" STREQUAL ".") + set(dst ${output_dir}/${file}) + add_custom_command(OUTPUT ${dst} + DEPENDS ${src} + COMMAND ${CMAKE_COMMAND} -E copy_if_different ${src} ${dst} + COMMENT "Copying clang's ${file}...") + list(APPEND out_files ${dst}) + else() + foreach(BUILD_MODE ${CMAKE_CONFIGURATION_TYPES}) + # Replace the special string with a per config directory. + string(REPLACE ${CMAKE_CFG_INTDIR} ${BUILD_MODE} per_conf_output_dir ${output_dir}) + set(dst ${per_conf_output_dir}/${file}) + add_custom_command(OUTPUT ${dst} + DEPENDS ${src} + COMMAND ${CMAKE_COMMAND} -E copy_if_different ${src} ${dst} + COMMENT "Copying clang's ${file}...") + list(APPEND out_files ${dst}) + endforeach() + endif() set(out_files ${out_files} PARENT_SCOPE) endfunction(copy_header_to_output_dir) _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits