https://github.com/PiotrZSL commented:
1. Overall ok, please work a little bit on an warning message. 2. Probably better name would be: readability-ambiguous-smartptr-reset-call 3. Same issue exist on other objects like std::optional, and other methods like std::optional<std::set> and call to `emplace`. Maybe more checks or more generic check could be constructed where configuration is an pair of "object" and "method". Consider points 1 & 2. And after that it could be delivered. https://github.com/llvm/llvm-project/pull/121291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
