frederick-vs-ja wrote: > > > @frederick-vs-ja just follow up on this, is there anything else I need to > > > address for this PR? > > > > > > It looks like you are missing the Release Notes entry, FTM is not set, etc. > > house keeping stuff. Please check some other complete PRs for what else you > > need to do. > > What's FTM? Can you give me an example PR that has those?
Just remove the `"unimplemented": True,` line and run the script. Then `<version>` and some test files are automatically changed. https://github.com/llvm/llvm-project/blob/776fa2d731c17d6ba0afad2554ebc89cf5e3e5ef/libcxx/utils/generate_feature_test_macro_components.py#L1065-L1070 https://github.com/llvm/llvm-project/pull/120920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits