https://github.com/loumalouomega updated https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?= <vmat...@altair.com> Date: Thu, 13 Feb 2025 15:28:30 +0100 Subject: [PATCH 1/2] [tool] Remove legacy argument `-ignore-insert-conflict` from `run-clang-tidy.py` --- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py | 1 - 1 file changed, 1 deletion(-) diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py index f1b934f7139e9..acee87c860aa0 100755 --- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py +++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py @@ -200,7 +200,6 @@ def apply_fixes( ) -> None: """Calls clang-apply-fixes on a given directory.""" invocation = [clang_apply_replacements_binary] - invocation.append("-ignore-insert-conflict") if args.format: invocation.append("-format") if args.style: From 65adc60c634d93eb2186ddb18ada0131698bcabe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?= <vmat...@altair.com> Date: Fri, 14 Feb 2025 09:35:47 +0100 Subject: [PATCH 2/2] Optional --- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py index acee87c860aa0..3301cf5a84a93 100755 --- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py +++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py @@ -198,8 +198,12 @@ def find_binary(arg: str, name: str, build_path: str) -> str: def apply_fixes( args: argparse.Namespace, clang_apply_replacements_binary: str, tmpdir: str ) -> None: - """Calls clang-apply-fixes on a given directory.""" + """Calls clang-apply-replacements on a given directory.""" invocation = [clang_apply_replacements_binary] + + if args.ignore_insert_conflict: # Only append if the user specified it + invocation.append("-ignore-insert-conflict") + if args.format: invocation.append("-format") if args.style: @@ -445,6 +449,11 @@ async def main() -> None: action="store_true", help="Allow empty enabled checks.", ) + parser.add_argument( + "-ignore-insert-conflict", + action="store_true", + help="Ignore insert conflict when applying fixes.", + ) args = parser.parse_args() db_path = "compile_commands.json" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits