================
@@ -1106,8 +1106,12 @@ bool AMDGPUToolChain::shouldSkipSanitizeOption(
 
   // For simplicity, we only allow -fsanitize=address
   SanitizerMask K = parseSanitizerValue(A->getValue(), /*AllowGroups=*/false);
-  if (K != SanitizerKind::Address)
+  if (K != SanitizerKind::Address) {
----------------
yxsamliu wrote:

moving diag to this function will cause repeated diagnostic message since the 
function is called for each argument.

you may want to refactor the diag handling to a common function but keep the 
call sites at their original locations.

https://github.com/llvm/llvm-project/pull/124754
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to