https://github.com/AaronBallman requested changes to this pull request.
Thank you for trying to take this on, we definitely appreciate when folks try to split things up to improve our ability to maintain the code base! That said, I don't think we need another file for common functions; Sema.cpp is already where I would expect those to live. If the functionality is only common to HLSL and SPIRV, maybe we want to consider a SemaOffload.cpp or something along those lines? But it's less clear to me how tightly we want to couple the relationships between all the various offload languages. I think this requires a broader design discussion with the impacted offloading maintainers. CC @llvm-beanz @jdoerfert @bader @alexey-bataev (It's unfortunate that the issue was marked good first issue; this has quite a bit of layering considerations that we've not really thought out yet.) https://github.com/llvm/llvm-project/pull/125045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
