llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) <details> <summary>Changes</summary> Silence MSVC warnings; NFC After the changes to DynamicRecursiveASTVisitor, we started getting several warnings from MSVC like: warning C4661: 'bool clang::DynamicRecursiveASTVisitorBase<false>::WalkUpFromNamedDecl(clang::NamedDecl *)': no suitable definition provided for explicit template instantiation request These changes silence the warnings by providing a definition for those functions. --- Full diff: https://github.com/llvm/llvm-project/pull/125100.diff 1 Files Affected: - (modified) clang/include/clang/AST/DynamicRecursiveASTVisitor.h (+2-2) ``````````diff diff --git a/clang/include/clang/AST/DynamicRecursiveASTVisitor.h b/clang/include/clang/AST/DynamicRecursiveASTVisitor.h index 4e0ba568263bf3..703cca22777ad0 100644 --- a/clang/include/clang/AST/DynamicRecursiveASTVisitor.h +++ b/clang/include/clang/AST/DynamicRecursiveASTVisitor.h @@ -251,11 +251,11 @@ template <bool IsConst> class DynamicRecursiveASTVisitorBase { // Decls. #define ABSTRACT_DECL(DECL) #define DECL(CLASS, BASE) \ + bool WalkUpFrom##CLASS##Decl(MaybeConst<CLASS##Decl> *D); \ virtual bool Traverse##CLASS##Decl(MaybeConst<CLASS##Decl> *D); #include "clang/AST/DeclNodes.inc" #define DECL(CLASS, BASE) \ - bool WalkUpFrom##CLASS##Decl(MaybeConst<CLASS##Decl> *D); \ virtual bool Visit##CLASS##Decl(MaybeConst<CLASS##Decl> *D) { return true; } #include "clang/AST/DeclNodes.inc" @@ -272,11 +272,11 @@ template <bool IsConst> class DynamicRecursiveASTVisitorBase { // Types. #define ABSTRACT_TYPE(CLASS, BASE) #define TYPE(CLASS, BASE) \ + bool WalkUpFrom##CLASS##Type(MaybeConst<CLASS##Type> *T); \ virtual bool Traverse##CLASS##Type(MaybeConst<CLASS##Type> *T); #include "clang/AST/TypeNodes.inc" #define TYPE(CLASS, BASE) \ - bool WalkUpFrom##CLASS##Type(MaybeConst<CLASS##Type> *T); \ virtual bool Visit##CLASS##Type(MaybeConst<CLASS##Type> *T) { return true; } #include "clang/AST/TypeNodes.inc" `````````` </details> https://github.com/llvm/llvm-project/pull/125100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
