https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/125022
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect C to be nonnull.
>From 13644f7244d9f219698316b529151cdf9daf938f Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Wed, 29 Jan 2025 08:58:09 -0800
Subject: [PATCH] [AST] Migrate away from PointerUnion::dyn_cast (NFC)
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect C to be nonnull.
---
clang/lib/AST/TextNodeDumper.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang/lib/AST/TextNodeDumper.cpp b/clang/lib/AST/TextNodeDumper.cpp
index a57cba959748222..bbb31a1e8d3f5c9 100644
--- a/clang/lib/AST/TextNodeDumper.cpp
+++ b/clang/lib/AST/TextNodeDumper.cpp
@@ -958,9 +958,9 @@ void TextNodeDumper::dumpAccessSpecifier(AccessSpecifier
AS) {
void TextNodeDumper::dumpCleanupObject(
const ExprWithCleanups::CleanupObject &C) {
- if (auto *BD = C.dyn_cast<BlockDecl *>())
+ if (auto *BD = dyn_cast<BlockDecl *>(C))
dumpDeclRef(BD, "cleanup");
- else if (auto *CLE = C.dyn_cast<CompoundLiteralExpr *>())
+ else if (auto *CLE = dyn_cast<CompoundLiteralExpr *>(C))
AddChild([=] {
OS << "cleanup ";
{
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
