================
@@ -10960,6 +10960,10 @@ OverloadCandidateSet::BestViableFunction(Sema &S, 
SourceLocation Loc,
     S.diagnoseEquivalentInternalLinkageDeclarations(Loc, Best->Function,
                                                     EquivalentCands);
 
+  // [over.match.best]/4 is checked for in Sema::ConvertArgumentsForCall,
+  // because not every function call goes through our overload resolution
+  // machinery, even if the Standard says it supposed to.
+
----------------
cor3ntin wrote:

do we have test for something like that

```
namespace A {
    extern "C" void f(long = 0); // viable candidate
}
namespace B {
    extern "C" void f(long = 0); // viable candidate
}

using A::f;
using B::f;

void f(int) {} // best candidate

void g() {
    f(0); // should not diagnose
}
```

https://github.com/llvm/llvm-project/pull/124844
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to