berenm added a comment.

In https://reviews.llvm.org/D30931#700690, @alexfh wrote:

> I understand your use case, but this patch makes the check's behavior more 
> confusing: having both "any case" and "ignore case" with subtle differences 
> in behavior seems very misleading. The problem seems to be coming from the 
> usage of `CT_AnyCase` to denote uninitialized style. Should we just remove 
> `NamingStyle::isSet` and use `llvm::Optional<NamingStyle>` instead of 
> `NamingStyle` where appropriate?


I agree


https://reviews.llvm.org/D30931



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to