llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) <details> <summary>Changes</summary> -fno-plt is an ELF specific option that GCC doesn't bother to give a diagnostic on Windows. This option is somewhat popular and we've been ignoring it for unsupported targets for a while (x86 support for a while, #<!-- -->78890 for AArch64 support), so just report a warning for unsupported object file formats. --- Full diff: https://github.com/llvm/llvm-project/pull/124081.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+2-3) - (added) clang/test/Driver/fno-plt.c (+7) ``````````diff diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 33f08cf28feca1..5df58005a52373 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -6141,9 +6141,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("-fno-direct-access-external-data"); } - if (Args.hasFlag(options::OPT_fno_plt, options::OPT_fplt, false)) { - CmdArgs.push_back("-fno-plt"); - } + if (Triple.isOSBinFormatELF()) + Args.addOptOutFlag(CmdArgs, options::OPT_fplt, options::OPT_fno_plt); // -fhosted is default. // TODO: Audit uses of KernelOrKext and see where it'd be more appropriate to diff --git a/clang/test/Driver/fno-plt.c b/clang/test/Driver/fno-plt.c new file mode 100644 index 00000000000000..d5189e2b508b2a --- /dev/null +++ b/clang/test/Driver/fno-plt.c @@ -0,0 +1,7 @@ +// RUN: %clang -### -c --target=aarch64 -fno-plt -Werror %s 2>&1 | FileCheck %s +// RUN: %clang -### -c --target=aarch64 -fno-plt -fplt -Werror %s 2>&1 | FileCheck %s --check-prefix=NO +// RUN: %clang -### -c --target=aarch64-windows -fno-plt %s 2>&1 | FileCheck %s --check-prefixes=WARN,NO + +// WARN: warning: argument unused during compilation: '-fno-plt' [-Wunused-command-line-argument] +// CHECK: "-fno-plt" +// NO-NOT: "-fno-plt" `````````` </details> https://github.com/llvm/llvm-project/pull/124081 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
