================ @@ -117,13 +121,13 @@ class OptTable { private: // A unified string table for these options. Individual strings are stored as // null terminated C-strings at offsets within this table. - const char *StrTable; + const StringTable *StrTable; ---------------- chandlerc wrote:
Using a const reference makes the type unassignable (without UB) sadly, because references can't be re-bound. Technically, this type could probably be unassignable, but I always prefer regular types that don't have complex constraints like that and so I much prefer pointers rather than references as members. That said, if there is a strong preference, I can try switching to a reference and see if I can get it all to compile. https://github.com/llvm/llvm-project/pull/123308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits