tahonermann wrote: > No idea why I can't respond to the individual threads but...
@erichkeane, in order to reduce notifications, I replied to your comments as a review. You should generally be able to reply to them individually or as part of a batched review from the "Files changed" tab, but GitHub doesn't permit such replies from the "Conversation" tab (which is weird and seems dumb). However, if the comments are considered "outdated" because of new commits that changed the code the thread was anchored too, then such comments appear to become orphaned; they still appear in the "Conversation" tab, but not in the "Filed changed" tab and therefore can't be replied to. GitHub is a less than perfect tool, IMHO of course. > make format happy, then LGTM. Thank you. I addressed the non-dumb clang-format complaints. I'll merge once @bader is happy with the changes. https://github.com/llvm/llvm-project/pull/122379 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
