================
@@ -7858,20 +7858,19 @@ bool
AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) {
Optionality);
return true;
}
- if (HasActiveSubsection &&
- (SubsectionName == ActiveSubsection->VendorName)) {
- if (IsOptional != ActiveSubsection->IsOptional) {
+ if (SubsectionExists) {
+ if (IsOptional != ExistingSubsection->IsOptional) {
Error(Parser.getTok().getLoc(),
"optionality mismatch! subsection '" + SubsectionName +
"' already exists with optionality defined as '" +
- Twine(ActiveSubsection->IsOptional) + "' and not '" +
+ Twine(ExistingSubsection->IsOptional) + "' and not '" +
Twine(IsOptional) + "' (0: required, 1: optional)");
----------------
ostannard wrote:
I think the numbers here are only used in the ELF encoding, so they aren't
relevant to the assembly programmer. The diagnostic should refer to the
identifiers used in the assembly.
https://github.com/llvm/llvm-project/pull/118771
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
