djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land.
Looks good. ================ Comment at: docs/tools/dump_format_style.py:67 def __str__(self): - return '* ``%s`` %s' % (self.name, doxygen2rst(self.comment)) + return '\n* ``%s`` %s' % (self.name, doxygen2rst(self.comment)) ---------------- sylvestre.ledru wrote: > This is needed to fix a bug in the generation of BraceWrappingFlags > The generation was failing because of a missing empty line with: > > > > > docs/ClangFormatStyleOptions.rst:480: (WARNING/2) Explicit markup ends > > without a blank line; unexpected unindent. > > > Let me know if you prefer to see that in a separate patch > The same patch is fine. Thanks for fixing this! https://reviews.llvm.org/D30860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
