a.sidorin added a comment.
Hello Zoltan,
Thank you for the patch. There is an inline comment.
================
Comment at: lib/AST/ASTImporter.cpp:5221
IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I));
- if (!ToII)
- return nullptr;
+ // ToII is nullptr when no symbolic name is given for output operand
+ // see ParseStmtAsm::ParseAsmOperandsOpt
----------------
In such cases, we should check that FromIdentifier is `nullptr` too (to detect
cases where the result is `nullptr` due to import error). The check will be
still present but will look like:
```
if (!ToII && S->getOutputIdentifier())
return nullptr;
```
The same below.
https://reviews.llvm.org/D30831
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
