Endilll wrote:

> No problem, I know everybody is busy.
> 
> > The first step is to get the PR out of draft state.
> 
> Do you just mean to mark it "read for review" or to apply changes so that it 
> can be merged? Because the current implementation is not ready as I still 
> have some questions as to how to implement things in order to pass the 
> failing tests.

I mean "ready for review". The draft status of your PR actively discourages 
anyone to look at it, while you need someone to look and answer your questions. 
It's not going to be merged unless you and reviewers are happy.

https://github.com/llvm/llvm-project/pull/115234
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to