https://github.com/CarolineConcatto approved this pull request.
Hi Momchil, I debated on this change, because it is undoing what I did previously and it is based on review feedback. The implementation is fine and correct. It is a matter of principles. I am going to approve because: 1) If we revert this patch in the future nothing should break as it is a NFC*(At least that is my understanding, with the exception of the change in file ASTContext.cpp) 2) There are a list of patches approved that depend on this. At least that is how I am approaching this implementation of mfp8. https://github.com/llvm/llvm-project/pull/118969 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
