llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) <details> <summary>Changes</summary> 1. add `static` for internal linkage functions 2. remove `clang` prefix for `QualType` --- Full diff: https://github.com/llvm/llvm-project/pull/122288.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp (+10-10) ``````````diff diff --git a/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp b/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp index 9c5c2f3939c99b..179173502a8d01 100644 --- a/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp @@ -59,7 +59,7 @@ static bool maxCondition(const BinaryOperator::Opcode Op, const Expr *CondLhs, return false; } -QualType getNonTemplateAlias(QualType QT) { +static QualType getNonTemplateAlias(QualType QT) { while (true) { // cast to a TypedefType if (const TypedefType *TT = dyn_cast<TypedefType>(QT)) { @@ -92,15 +92,15 @@ static std::string createReplacement(const Expr *CondLhs, const Expr *CondRhs, const llvm::StringRef AssignLhsStr = Lexer::getSourceText( Source.getExpansionRange(AssignLhs->getSourceRange()), Source, LO); - clang::QualType GlobalImplicitCastType; - clang::QualType LhsType = CondLhs->getType() - .getCanonicalType() - .getNonReferenceType() - .getUnqualifiedType(); - clang::QualType RhsType = CondRhs->getType() - .getCanonicalType() - .getNonReferenceType() - .getUnqualifiedType(); + QualType GlobalImplicitCastType; + QualType LhsType = CondLhs->getType() + .getCanonicalType() + .getNonReferenceType() + .getUnqualifiedType(); + QualType RhsType = CondRhs->getType() + .getCanonicalType() + .getNonReferenceType() + .getUnqualifiedType(); if (LhsType != RhsType) { GlobalImplicitCastType = getNonTemplateAlias(BO->getLHS()->getType()); } `````````` </details> https://github.com/llvm/llvm-project/pull/122288 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
