djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land.
Please upload patches with full context or use arc (https://secure.phabricator.com/book/phabricator/article/arcanist/). Generally looks good, just minor comments. ================ Comment at: include/clang/Format/Format.h:201 enum DefinitionReturnTypeBreakingStyle { /// Break after return type automatically. ---------------- Don't add examples here as this is deprecated. Maybe make it more obvious that this is deprecated instead. ================ Comment at: include/clang/Format/Format.h:726 /// \brief If ``true``, a space may be inserted after C style casts. + /// \code ---------------- While you are here: s/may be/is/ https://reviews.llvm.org/D30734 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
