mprobst marked 2 inline comments as done. mprobst added inline comments.
================ Comment at: lib/Format/TokenAnnotator.cpp:1056 + } else if (Current.is(tok::exclaim)) { + if (Style.Language == FormatStyle::LK_JavaScript) { + if (Current.Previous && ---------------- djasper wrote: > I wonder whether we should do this logic "inside out", i.e. have > language-specific parts at the top (or in a separate function). We have > started that in mustBreakBefore and I think that's helpful. > > I can do this in a follow-up, though. Yeah, I was debating that but wanted to stick with the code style. Done. https://reviews.llvm.org/D30705 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits