Author: Benjamin Kramer Date: 2025-01-08T16:16:46+01:00 New Revision: a3b4d9147406cbd90090466a9b2b9bb2e9f6000c
URL: https://github.com/llvm/llvm-project/commit/a3b4d9147406cbd90090466a9b2b9bb2e9f6000c DIFF: https://github.com/llvm/llvm-project/commit/a3b4d9147406cbd90090466a9b2b9bb2e9f6000c.diff LOG: Fix -Wdangling-assignment-gsl in ClangdLSPServerTests I think this is a false positive for a non-capturing lambda, but I can't find anything in the standard that guarantees that these have eternal lifetime. Added: Modified: clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp b/clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp index 49a94045ea4878..2c7f50d8c9e4ce 100644 --- a/clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp +++ b/clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp @@ -208,12 +208,13 @@ TEST_F(LSPTest, ClangTidyRename) { Annotations Source(R"cpp( void [[foo]]() {} )cpp"); - Opts.ClangTidyProvider = [](tidy::ClangTidyOptions &ClangTidyOpts, - llvm::StringRef) { + constexpr auto ClangTidyProvider = [](tidy::ClangTidyOptions &ClangTidyOpts, + llvm::StringRef) { ClangTidyOpts.Checks = {"-*,readability-identifier-naming"}; ClangTidyOpts.CheckOptions["readability-identifier-naming.FunctionCase"] = "CamelCase"; }; + Opts.ClangTidyProvider = ClangTidyProvider; auto &Client = start(); Client.didOpen("foo.hpp", Header.code()); Client.didOpen("foo.cpp", Source.code()); @@ -266,10 +267,11 @@ TEST_F(LSPTest, ClangTidyCrash_Issue109367) { // This test requires clang-tidy checks to be linked in. if (!CLANGD_TIDY_CHECKS) return; - Opts.ClangTidyProvider = [](tidy::ClangTidyOptions &ClangTidyOpts, - llvm::StringRef) { + constexpr auto ClangTidyProvider = [](tidy::ClangTidyOptions &ClangTidyOpts, + llvm::StringRef) { ClangTidyOpts.Checks = {"-*,boost-use-ranges"}; }; + Opts.ClangTidyProvider = ClangTidyProvider; // Check that registering the boost-use-ranges checker's matchers // on two diff erent threads does not cause a crash. auto &Client = start(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
