=?utf-8?q?André?= Brand <andre.br...@mailbox.org> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/121...@github.com>
thebrandre wrote: @cor3ntin I hope there is no misunderstanding here. If so, I apologize, I strongly agree with you that some refactoring should be applied because, as I mentioned, the diagnostics get duplicated in certain cases as shown here on Compiler Explorer: [https://godbolt.org/z/473Eezhjn](https://godbolt.org/z/473Eezhjn). But I would prefer opening another pull request for it keeping it separate from the fix making it easier to cherry-pick. My understanding is that all commits get squashed before being applied to main? If there is still something wrong with the commit message, I would gladly give it another try if you could be more specific. https://github.com/llvm/llvm-project/pull/121039 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
