https://github.com/NagyDonat approved this pull request.

LGTM, thanks for this improvement. Using the "raw" ordering of pointers is 
always a red flag, I strongly support eliminating it if possible.

By the way, what fraction of the results is perturbed (replaced with other 
random results) when this commit is activated? Did you run any "without this 
commit vs with this commit" comparisons?

As a tangential remark, I noticed that there seems to be heavy code duplication 
between the `getXSymbol` methods of `SymbolManager` -- it would be nice to 
unify them into a single template method that takes the symbol class and the 
argument list types as template parameters (analogously to 
`SymExprAllocator::make` which does similar forwarding). However, this probably 
belongs to a separate NFC refactoring commit (and I can also implement it if 
you don't have time for it). What do you think? Do you see any obstacle (or 
perhaps conflict with changes that you're planning).



https://github.com/llvm/llvm-project/pull/121551
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to