ricejasonf wrote: That crash looks like a result of my call to setDecomposedDecl(nullptr) in the BindingsInitWalker stuff. I don't remember why I don't set that. I will check it out when I try to clean that up.
> But that also makes it confusing as to this implementation - I suggest avoiding unrelated changes for better clarity and safety. WDYT? The change is related. We do not set `Name` for ResolvedUnexpandedPackExprs. It was previously assuming the remaining case must be NamedDecl. On Thu, Jan 2, 2025 at 10:06 PM Younan Zhang ***@***.***> wrote: > ***@***.**** commented on this pull request. > > Here is an interesting case involving lambda captures: > > https://godbolt.org/z/Y7EhE7Gvq > > (Everything would become scary when lambda comes into play) > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/121417#pullrequestreview-2528589663>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AARHBFFR5PST2GGKPWMISRD2IYSH3AVCNFSM6AAAAABUN63362VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRYGU4DSNRWGM> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > https://github.com/llvm/llvm-project/pull/121417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
