https://github.com/steakhal commented:

The content look narrow and precise.
It raises me questions why is the only user of this new field the Constraint 
manager?
And if the constraint manager is the only user, why is the SMT-based solver not 
using this? Should all the other immutableSet/Map benefit from this stability 
when the key is a SymbolRef?
Why can't the default Profile changed for SymExpr to automatically "opt-in" 
this new ordering for the rest of the foldingset-user datastructures, such as 
DenseSet/Map too?

https://github.com/llvm/llvm-project/pull/121347
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to