================ @@ -3246,8 +3246,15 @@ tooling::Replacements sortCppIncludes(const FormatStyle &Style, StringRef Code, SmallVector<StringRef, 2> RawStringMatches; std::string RawStringTermination = ")\""; - for (;;) { - auto Pos = Code.find('\n', SearchFrom); + for (const auto Size = Code.size(); SearchFrom < Size;) { ---------------- owenca wrote:
Because it's used in `SearchFrom < Size`. My previous version using `for (;;)` caused a crash in ToolingTests. https://github.com/llvm/llvm-project/pull/120680 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits