https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/120245
>From 9e47698969dc59df1abaa8abd243b97e8fa038c3 Mon Sep 17 00:00:00 2001
From: Congcong Cai <congcongcai0...@163.com>
Date: Tue, 17 Dec 2024 23:31:52 +0800
Subject: [PATCH 1/3] [clang-tidy][NFC] swap
cppcoreguidelines-narrowing-conversions and bugprone-narrowing-conversions
According to #116591.
> Coding guidelines should "cherry-pick" (and posddsibly configure/harden/make
> more strict) base checks.
We should move narrowing conversion to bugprone and keep alias in
cppcoreguidelines
---
.../bugprone/BugproneTidyModule.cpp | 4 +-
.../clang-tidy/bugprone/CMakeLists.txt | 1 +
.../NarrowingConversionsCheck.cpp | 2 +-
.../NarrowingConversionsCheck.h | 2 +-
.../cppcoreguidelines/CMakeLists.txt | 1 -
.../CppCoreGuidelinesTidyModule.cpp | 4 +-
.../checks/bugprone/narrowing-conversions.rst | 93 +++++++++++++++++-
.../narrowing-conversions.rst | 91 +----------------
.../narrowing-conversions-bitfields.cpp | 4 +-
...-conversions-equivalentbitwidth-option.cpp | 20 ++--
...sions-ignoreconversionfromtypes-option.cpp | 28 +++---
...rrowing-conversions-intemplates-option.cpp | 12 +--
.../narrowing-conversions-long-is-32bits.cpp | 6 +-
...versions-narrowingfloatingpoint-option.cpp | 24 ++---
...ng-conversions-narrowinginteger-option.cpp | 16 +--
...narrowingintegertofloatingpoint-option.cpp | 19 ++++
...rowing-conversions-pedanticmode-option.cpp | 12 +--
.../narrowing-conversions-unsigned-char.cpp | 22 ++---
.../narrowing-conversions.cpp | 98 +++++++++----------
...narrowingintegertofloatingpoint-option.cpp | 19 ----
20 files changed, 240 insertions(+), 238 deletions(-)
rename clang-tools-extra/clang-tidy/{cppcoreguidelines =>
bugprone}/NarrowingConversionsCheck.cpp (99%)
rename clang-tools-extra/clang-tidy/{cppcoreguidelines =>
bugprone}/NarrowingConversionsCheck.h (99%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-bitfields.cpp (97%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-equivalentbitwidth-option.cpp (66%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-ignoreconversionfromtypes-option.cpp (75%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-intemplates-option.cpp (73%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-long-is-32bits.cpp (84%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-narrowingfloatingpoint-option.cpp (70%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-narrowinginteger-option.cpp (59%)
create mode 100644
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-pedanticmode-option.cpp (52%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions-unsigned-char.cpp (80%)
rename clang-tools-extra/test/clang-tidy/checkers/{cppcoreguidelines =>
bugprone}/narrowing-conversions.cpp (77%)
delete mode 100644
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
diff --git a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
index 33ac65e715ce81..c55acf0f4e1803 100644
--- a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
@@ -9,7 +9,6 @@
#include "../ClangTidy.h"
#include "../ClangTidyModule.h"
#include "../ClangTidyModuleRegistry.h"
-#include "../cppcoreguidelines/NarrowingConversionsCheck.h"
#include "ArgumentCommentCheck.h"
#include "AssertSideEffectCheck.h"
#include "AssignmentInIfConditionCheck.h"
@@ -17,6 +16,7 @@
#include "BitwisePointerCastCheck.h"
#include "BoolPointerImplicitConversionCheck.h"
#include "BranchCloneCheck.h"
+#include "NarrowingConversionsCheck.h"
#include "CastingThroughVoidCheck.h"
#include "ChainedComparisonCheck.h"
#include "ComparePointerToMemberVirtualFunctionCheck.h"
@@ -183,7 +183,7 @@ class BugproneModule : public ClangTidyModule {
"bugprone-pointer-arithmetic-on-polymorphic-object");
CheckFactories.registerCheck<RedundantBranchConditionCheck>(
"bugprone-redundant-branch-condition");
- CheckFactories.registerCheck<cppcoreguidelines::NarrowingConversionsCheck>(
+ CheckFactories.registerCheck<NarrowingConversionsCheck>(
"bugprone-narrowing-conversions");
CheckFactories.registerCheck<NoEscapeCheck>("bugprone-no-escape");
CheckFactories.registerCheck<NonZeroEnumToBoolConversionCheck>(
diff --git a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
index 13adad7c3dadbd..73ab22381631c8 100644
--- a/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
@@ -42,6 +42,7 @@ add_clang_library(clangTidyBugproneModule STATIC
MultiLevelImplicitPointerConversionCheck.cpp
MultipleNewInOneExpressionCheck.cpp
MultipleStatementMacroCheck.cpp
+ NarrowingConversionsCheck.cpp
NoEscapeCheck.cpp
NonZeroEnumToBoolConversionCheck.cpp
NondeterministicPointerIterationOrderCheck.cpp
diff --git
a/clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
similarity index 99%
rename from
clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
rename to clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
index 45fef9471d5211..7c9903c20ac6a6 100644
---
a/clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
@@ -22,7 +22,7 @@
using namespace clang::ast_matchers;
-namespace clang::tidy::cppcoreguidelines {
+namespace clang::tidy::bugprone {
namespace {
diff --git
a/clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h
b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
similarity index 99%
rename from
clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h
rename to clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
index 1add40b91778a3..eb7b920c1aff63 100644
--- a/clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.h
+++ b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
@@ -11,7 +11,7 @@
#include "../ClangTidyCheck.h"
-namespace clang::tidy::cppcoreguidelines {
+namespace clang::tidy::bugprone {
/// Checks for narrowing conversions, e.g:
/// int i = 0;
diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt
b/clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt
index 07bb89ec7937a0..1f4107c0b35e70 100644
--- a/clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt
@@ -16,7 +16,6 @@ add_clang_library(clangTidyCppCoreGuidelinesModule STATIC
MacroUsageCheck.cpp
MisleadingCaptureDefaultByValueCheck.cpp
MissingStdForwardCheck.cpp
- NarrowingConversionsCheck.cpp
NoMallocCheck.cpp
NoSuspendWithLockCheck.cpp
OwningMemoryCheck.cpp
diff --git
a/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
b/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
index e9f0201615616f..4dded38482e688 100644
---
a/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
+++
b/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
@@ -30,7 +30,7 @@
#include "MacroUsageCheck.h"
#include "MisleadingCaptureDefaultByValueCheck.h"
#include "MissingStdForwardCheck.h"
-#include "NarrowingConversionsCheck.h"
+#include "../bugprone/NarrowingConversionsCheck.h"
#include "NoMallocCheck.h"
#include "NoSuspendWithLockCheck.h"
#include "OwningMemoryCheck.h"
@@ -87,7 +87,7 @@ class CppCoreGuidelinesModule : public ClangTidyModule {
"cppcoreguidelines-misleading-capture-default-by-value");
CheckFactories.registerCheck<MissingStdForwardCheck>(
"cppcoreguidelines-missing-std-forward");
- CheckFactories.registerCheck<NarrowingConversionsCheck>(
+ CheckFactories.registerCheck<bugprone::NarrowingConversionsCheck>(
"cppcoreguidelines-narrowing-conversions");
CheckFactories.registerCheck<NoMallocCheck>("cppcoreguidelines-no-malloc");
CheckFactories.registerCheck<NoSuspendWithLockCheck>(
diff --git
a/clang-tools-extra/docs/clang-tidy/checks/bugprone/narrowing-conversions.rst
b/clang-tools-extra/docs/clang-tidy/checks/bugprone/narrowing-conversions.rst
index f4bb40b341bcdd..3ec0edbe0906da 100644
---
a/clang-tools-extra/docs/clang-tidy/checks/bugprone/narrowing-conversions.rst
+++
b/clang-tools-extra/docs/clang-tidy/checks/bugprone/narrowing-conversions.rst
@@ -1,10 +1,93 @@
.. title:: clang-tidy - bugprone-narrowing-conversions
-.. meta::
- :http-equiv=refresh: 5;URL=../cppcoreguidelines/narrowing-conversions.html
bugprone-narrowing-conversions
==============================
-The bugprone-narrowing-conversions check is an alias, please see
-:doc:`cppcoreguidelines-narrowing-conversions
<../cppcoreguidelines/narrowing-conversions>`
-for more information.
+`cppcoreguidelines-narrowing-conversions` redirects here as an alias for this
check.
+
+Checks for silent narrowing conversions, e.g: ``int i = 0; i += 0.1;``. While
+the issue is obvious in this former example, it might not be so in the
+following: ``void MyClass::f(double d) { int_member_ += d; }``.
+
+We enforce only part of the guideline, more specifically, we flag narrowing
conversions from:
+ - an integer to a narrower integer (e.g. ``char`` to ``unsigned char``)
+ if WarnOnIntegerNarrowingConversion Option is set,
+ - an integer to a narrower floating-point (e.g. ``uint64_t`` to ``float``)
+ if WarnOnIntegerToFloatingPointNarrowingConversion Option is set,
+ - a floating-point to an integer (e.g. ``double`` to ``int``),
+ - a floating-point to a narrower floating-point (e.g. ``double`` to ``float``)
+ if WarnOnFloatingPointNarrowingConversion Option is set.
+
+This check will flag:
+ - All narrowing conversions that are not marked by an explicit cast (c-style
or
+ ``static_cast``). For example: ``int i = 0; i += 0.1;``,
+ ``void f(int); f(0.1);``,
+ - All applications of binary operators with a narrowing conversions.
+ For example: ``int i; i+= 0.1;``.
+
+
+Options
+-------
+
+.. option:: WarnOnIntegerNarrowingConversion
+
+ When `true`, the check will warn on narrowing integer conversion
+ (e.g. ``int`` to ``size_t``). `true` by default.
+
+.. option:: WarnOnIntegerToFloatingPointNarrowingConversion
+
+ When `true`, the check will warn on narrowing integer to floating-point
+ conversion (e.g. ``size_t`` to ``double``). `true` by default.
+
+.. option:: WarnOnFloatingPointNarrowingConversion
+
+ When `true`, the check will warn on narrowing floating point conversion
+ (e.g. ``double`` to ``float``). `true` by default.
+
+.. option:: WarnWithinTemplateInstantiation
+
+ When `true`, the check will warn on narrowing conversions within template
+ instantiations. `false` by default.
+
+.. option:: WarnOnEquivalentBitWidth
+
+ When `true`, the check will warn on narrowing conversions that arise from
+ casting between types of equivalent bit width. (e.g.
+ `int n = uint(0);` or `long long n = double(0);`) `true` by default.
+
+.. option:: IgnoreConversionFromTypes
+
+ Narrowing conversions from any type in this semicolon-separated list will be
+ ignored. This may be useful to weed out commonly occurring, but less
commonly
+ problematic assignments such as `int n = std::vector<char>().size();` or
+ `int n = std::difference(it1, it2);`. The default list is empty, but one
+ suggested list for a legacy codebase would be
+ `size_t;ptrdiff_t;size_type;difference_type`.
+
+.. option:: PedanticMode
+
+ When `true`, the check will warn on assigning a floating point constant
+ to an integer value even if the floating point value is exactly
+ representable in the destination type (e.g. ``int i = 1.0;``).
+ `false` by default.
+
+FAQ
+---
+
+ - What does "narrowing conversion from 'int' to 'float'" mean?
+
+An IEEE754 Floating Point number can represent all integer values in the range
+[-2^PrecisionBits, 2^PrecisionBits] where PrecisionBits is the number of bits
in
+the mantissa.
+
+For ``float`` this would be [-2^23, 2^23], where ``int`` can represent values
in
+the range [-2^31, 2^31-1].
+
+ - What does "implementation-defined" mean?
+
+You may have encountered messages like "narrowing conversion from 'unsigned
int'
+to signed type 'int' is implementation-defined".
+The C/C++ standard does not mandate two's complement for signed integers, and
so
+the compiler is free to define what the semantics are for converting an
unsigned
+integer to signed integer. Clang's implementation uses the two's complement
+format.
diff --git
a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/narrowing-conversions.rst
b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/narrowing-conversions.rst
index 04260e75aa558f..59d2d86aca1dd4 100644
---
a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/narrowing-conversions.rst
+++
b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/narrowing-conversions.rst
@@ -1,95 +1,14 @@
.. title:: clang-tidy - cppcoreguidelines-narrowing-conversions
+.. meta::
+ :http-equiv=refresh: 5;URL=../cppcoreguidelines/narrowing-conversions.html
cppcoreguidelines-narrowing-conversions
=======================================
-Checks for silent narrowing conversions, e.g: ``int i = 0; i += 0.1;``. While
-the issue is obvious in this former example, it might not be so in the
-following: ``void MyClass::f(double d) { int_member_ += d; }``.
-
This check implements `ES.46
<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es46-avoid-lossy-narrowing-truncating-arithmetic-conversions>`_
from the C++ Core Guidelines.
-We enforce only part of the guideline, more specifically, we flag narrowing
conversions from:
- - an integer to a narrower integer (e.g. ``char`` to ``unsigned char``)
- if WarnOnIntegerNarrowingConversion Option is set,
- - an integer to a narrower floating-point (e.g. ``uint64_t`` to ``float``)
- if WarnOnIntegerToFloatingPointNarrowingConversion Option is set,
- - a floating-point to an integer (e.g. ``double`` to ``int``),
- - a floating-point to a narrower floating-point (e.g. ``double`` to ``float``)
- if WarnOnFloatingPointNarrowingConversion Option is set.
-
-This check will flag:
- - All narrowing conversions that are not marked by an explicit cast (c-style
or
- ``static_cast``). For example: ``int i = 0; i += 0.1;``,
- ``void f(int); f(0.1);``,
- - All applications of binary operators with a narrowing conversions.
- For example: ``int i; i+= 0.1;``.
-
-
-Options
--------
-
-.. option:: WarnOnIntegerNarrowingConversion
-
- When `true`, the check will warn on narrowing integer conversion
- (e.g. ``int`` to ``size_t``). `true` by default.
-
-.. option:: WarnOnIntegerToFloatingPointNarrowingConversion
-
- When `true`, the check will warn on narrowing integer to floating-point
- conversion (e.g. ``size_t`` to ``double``). `true` by default.
-
-.. option:: WarnOnFloatingPointNarrowingConversion
-
- When `true`, the check will warn on narrowing floating point conversion
- (e.g. ``double`` to ``float``). `true` by default.
-
-.. option:: WarnWithinTemplateInstantiation
-
- When `true`, the check will warn on narrowing conversions within template
- instantiations. `false` by default.
-
-.. option:: WarnOnEquivalentBitWidth
-
- When `true`, the check will warn on narrowing conversions that arise from
- casting between types of equivalent bit width. (e.g.
- `int n = uint(0);` or `long long n = double(0);`) `true` by default.
-
-.. option:: IgnoreConversionFromTypes
-
- Narrowing conversions from any type in this semicolon-separated list will be
- ignored. This may be useful to weed out commonly occurring, but less
commonly
- problematic assignments such as `int n = std::vector<char>().size();` or
- `int n = std::difference(it1, it2);`. The default list is empty, but one
- suggested list for a legacy codebase would be
- `size_t;ptrdiff_t;size_type;difference_type`.
-
-.. option:: PedanticMode
-
- When `true`, the check will warn on assigning a floating point constant
- to an integer value even if the floating point value is exactly
- representable in the destination type (e.g. ``int i = 1.0;``).
- `false` by default.
-
-FAQ
----
-
- - What does "narrowing conversion from 'int' to 'float'" mean?
-
-An IEEE754 Floating Point number can represent all integer values in the range
-[-2^PrecisionBits, 2^PrecisionBits] where PrecisionBits is the number of bits
in
-the mantissa.
-
-For ``float`` this would be [-2^23, 2^23], where ``int`` can represent values
in
-the range [-2^31, 2^31-1].
-
- - What does "implementation-defined" mean?
-
-You may have encountered messages like "narrowing conversion from 'unsigned
int'
-to signed type 'int' is implementation-defined".
-The C/C++ standard does not mandate two's complement for signed integers, and
so
-the compiler is free to define what the semantics are for converting an
unsigned
-integer to signed integer. Clang's implementation uses the two's complement
-format.
+The cppcoreguidelines-narrowing-conversions check is an alias, please see
+:doc:`bugprone-narrowing-conversions <../bugprone/narrowing-conversions>`
+for more information.
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-bitfields.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-bitfields.cpp
similarity index 97%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-bitfields.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-bitfields.cpp
index 36fde38202efcd..a7bb3c8d0c0c7e 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-bitfields.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-bitfields.cpp
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: %check_clang_tidy %s bugprone-narrowing-conversions %t \
// RUN: -std=c++17 -- -target x86_64-unknown-linux
#define CHAR_BITS 8
@@ -31,7 +31,7 @@ struct CompleteBitfield {
};
int example_warning(unsigned x) {
- // CHECK-MESSAGES: :[[@LINE+1]]:10: warning: narrowing conversion from
'unsigned int' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE+1]]:10: warning: narrowing conversion from
'unsigned int' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
return x;
}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-equivalentbitwidth-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-equivalentbitwidth-option.cpp
similarity index 66%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-equivalentbitwidth-option.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-equivalentbitwidth-option.cpp
index fb5c7e36eeb0df..0deb0067113673 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-equivalentbitwidth-option.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-equivalentbitwidth-option.cpp
@@ -1,35 +1,35 @@
// RUN: %check_clang_tidy -check-suffix=DEFAULT %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t --
+// RUN: bugprone-narrowing-conversions %t --
// RUN: %check_clang_tidy -check-suffix=DISABLED %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
+// RUN: bugprone-narrowing-conversions %t -- \
// RUN: -config='{CheckOptions: { \
-// RUN: cppcoreguidelines-narrowing-conversions.WarnOnEquivalentBitWidth:
0}}'
+// RUN: bugprone-narrowing-conversions.WarnOnEquivalentBitWidth: 0}}'
void narrowing_equivalent_bitwidth() {
int i;
unsigned int ui;
i = ui;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'unsigned int' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'unsigned int' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
// DISABLED: Warning disabled with WarnOnEquivalentBitWidth=0.
float f;
i = f;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'float' to 'int' [bugprone-narrowing-conversions]
// DISABLED: Warning disabled with WarnOnEquivalentBitWidth=0.
f = i;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'int' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'int' to 'float' [bugprone-narrowing-conversions]
// DISABLED: Warning disabled with WarnOnEquivalentBitWidth=0.
long long ll;
double d;
ll = d;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'double' to 'long long' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'double' to 'long long' [bugprone-narrowing-conversions]
// DISABLED: Warning disabled with WarnOnEquivalentBitWidth=0.
d = ll;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'long long' to 'double' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'long long' to 'double' [bugprone-narrowing-conversions]
// DISABLED: Warning disabled with WarnOnEquivalentBitWidth=0.
}
@@ -37,6 +37,6 @@ void most_narrowing_is_not_ok() {
int i;
long long ui;
i = ui;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES-DISABLED: :[[@LINE-2]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
+ // CHECK-MESSAGES-DISABLED: :[[@LINE-2]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-ignoreconversionfromtypes-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-ignoreconversionfromtypes-option.cpp
similarity index 75%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-ignoreconversionfromtypes-option.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-ignoreconversionfromtypes-option.cpp
index 91e908f535a0d4..6d93f5d642b5e4 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-ignoreconversionfromtypes-option.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-ignoreconversionfromtypes-option.cpp
@@ -1,10 +1,10 @@
// RUN: %check_clang_tidy -check-suffix=DEFAULT %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t --
+// RUN: bugprone-narrowing-conversions %t --
// RUN: %check_clang_tidy -check-suffix=IGNORED %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
+// RUN: bugprone-narrowing-conversions %t -- \
// RUN: -config='{CheckOptions: { \
-// RUN: cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes:
"global_size_t;nested_size_type;long" \
+// RUN: bugprone-narrowing-conversions.IgnoreConversionFromTypes:
"global_size_t;nested_size_type;long" \
// RUN: }}'
// We use global_size_t instead of 'size_t' because windows predefines size_t.
@@ -20,7 +20,7 @@ void narrowing_global_size_t() {
int i;
global_size_t j;
i = j;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with IgnoreConversionFromTypes=global_size_t.
}
@@ -28,7 +28,7 @@ void narrowing_size_type() {
int i;
vector::nested_size_type j;
i = j;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'vector::nested_size_type' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'vector::nested_size_type' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with
IgnoreConversionFromTypes=nested_size_type.
}
@@ -36,11 +36,11 @@ void narrowing_size_method() {
vector v;
int i, j;
i = v.size();
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with IgnoreConversionFromTypes=global_size_t.
i = j + v.size();
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with IgnoreConversionFromTypes=global_size_t.
}
@@ -49,7 +49,7 @@ void narrowing_size_method_binary_expr() {
int j;
vector v;
i = j + v.size();
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with IgnoreConversionFromTypes=global_size_t.
}
@@ -57,11 +57,11 @@ void narrowing_size_method_binary_op() {
int i, j;
vector v;
i += v.size();
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with IgnoreConversionFromTypes=global_size_t.
i += j + v.size();
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'global_size_t' (aka 'long long') to signed type 'int' is
implementation-defined [bugprone-narrowing-conversions]
// IGNORED: Warning is disabled with IgnoreConversionFromTypes=global_size_t.
}
@@ -69,13 +69,13 @@ void most_narrowing_is_not_ok() {
int i;
long long j;
i = j;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES-IGNORED: :[[@LINE-2]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
+ // CHECK-MESSAGES-IGNORED: :[[@LINE-2]]:7: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
}
void test_ignore_builtin_type_pr58809() {
long x = 123;
short y = x;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:13: warning: narrowing conversion
from 'long' to signed type 'short' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES-NOT-IGNORED: :[[@LINE-2]]:13: warning: narrowing
conversion from 'long' to signed type 'short' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:13: warning: narrowing conversion
from 'long' to signed type 'short' is implementation-defined
[bugprone-narrowing-conversions]
+ // CHECK-MESSAGES-NOT-IGNORED: :[[@LINE-2]]:13: warning: narrowing
conversion from 'long' to signed type 'short' is implementation-defined
[bugprone-narrowing-conversions]
}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-intemplates-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-intemplates-option.cpp
similarity index 73%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-intemplates-option.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-intemplates-option.cpp
index cb19ed78cce8a7..625dc45abcbecd 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-intemplates-option.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-intemplates-option.cpp
@@ -1,10 +1,10 @@
// RUN: %check_clang_tidy -check-suffix=DEFAULT %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t --
+// RUN: bugprone-narrowing-conversions %t --
// RUN: %check_clang_tidy -check-suffix=WARN %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
+// RUN: bugprone-narrowing-conversions %t -- \
// RUN: -config='{CheckOptions: { \
-// RUN:
cppcoreguidelines-narrowing-conversions.WarnWithinTemplateInstantiation: 1 \
+// RUN: bugprone-narrowing-conversions.WarnWithinTemplateInstantiation: 1 \
// RUN: }}'
template <typename OrigType>
@@ -12,7 +12,7 @@ void assign_in_template(OrigType jj) {
int ii;
ii = jj;
// DEFAULT: Warning disabled because WarnWithinTemplateInstantiation=0.
- // CHECK-MESSAGES-WARN: :[[@LINE-2]]:8: warning: narrowing conversion from
'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-WARN: :[[@LINE-2]]:8: warning: narrowing conversion from
'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
}
void narrow_inside_template_not_ok() {
@@ -23,8 +23,8 @@ void narrow_inside_template_not_ok() {
void assign_outside_template(long long jj) {
int ii;
ii = jj;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES-WARN: :[[@LINE-2]]:8: warning: narrowing conversion from
'long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:8: warning: narrowing conversion
from 'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
+ // CHECK-MESSAGES-WARN: :[[@LINE-2]]:8: warning: narrowing conversion from
'long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
}
void narrow_outside_template_not_ok() {
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-long-is-32bits.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-long-is-32bits.cpp
similarity index 84%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-long-is-32bits.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-long-is-32bits.cpp
index dcf1848a30f664..8e801a0eeea37a 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-long-is-32bits.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-long-is-32bits.cpp
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: %check_clang_tidy %s bugprone-narrowing-conversions %t \
// RUN: -- -- -target x86_64-unknown-linux -m32
static_assert(sizeof(int) * 8 == 32, "int is 32-bits");
@@ -16,8 +16,8 @@ void narrow_integer_to_signed_integer_is_not_ok() {
i = l; // int and long are the same type.
i = ll; // int64_t does not fit in an int32_t
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long
long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long
long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
ll = ul; // uint32_t fits into int64_t
ll = ull; // uint64_t does not fit in an int64_t
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long long' to signed type 'long long' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long long' to signed type 'long long' is implementation-defined
[bugprone-narrowing-conversions]
}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingfloatingpoint-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingfloatingpoint-option.cpp
similarity index 70%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingfloatingpoint-option.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingfloatingpoint-option.cpp
index 6cad3204c18e41..9ded2f0923f4e6 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingfloatingpoint-option.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingfloatingpoint-option.cpp
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: %check_clang_tidy %s bugprone-narrowing-conversions %t \
// RUN: -- -- -target x86_64-unknown-linux -fsigned-char
namespace floats {
@@ -6,15 +6,15 @@ namespace floats {
void narrow_constant_floating_point_to_int_not_ok(double d) {
int i = 0;
i += 0.5;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [bugprone-narrowing-conversions]
i += 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i *= 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i /= 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i += (double)0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [bugprone-narrowing-conversions]
i += 2.0;
i += 2.0f;
}
@@ -28,11 +28,11 @@ float narrow_double_to_float_return() {
void narrow_double_to_float_not_ok(double d) {
float f;
f = d;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'double' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'double' to 'float' [bugprone-narrowing-conversions]
f = 15_double;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'double' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'double' to 'float' [bugprone-narrowing-conversions]
f += d;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'double' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'double' to 'float' [bugprone-narrowing-conversions]
f = narrow_double_to_float_return();
}
@@ -46,11 +46,11 @@ void narrow_fp_constants() {
f = __builtin_nanf("0"); // float NaN is not narrowing.
f = __builtin_huge_val(); // max double is not within-range of float.
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'double' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'double' to 'float' [bugprone-narrowing-conversions]
f = -__builtin_huge_val(); // -max double is not within-range of float.
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'double' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'double' to 'float' [bugprone-narrowing-conversions]
f = __builtin_inf(); // double infinity is not within-range of float.
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'double' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'double' to 'float' [bugprone-narrowing-conversions]
f = __builtin_nan("0"); // double NaN is not narrowing.
}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowinginteger-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowinginteger-option.cpp
similarity index 59%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowinginteger-option.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowinginteger-option.cpp
index f58de65f042328..fce90ecf0881dc 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowinginteger-option.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowinginteger-option.cpp
@@ -1,23 +1,23 @@
// RUN: %check_clang_tidy -check-suffix=DEFAULT %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
-// RUN: -config='{CheckOptions:
{cppcoreguidelines-narrowing-conversions.WarnOnIntegerNarrowingConversion:
true}}'
+// RUN: bugprone-narrowing-conversions %t -- \
+// RUN: -config='{CheckOptions:
{bugprone-narrowing-conversions.WarnOnIntegerNarrowingConversion: true}}'
// RUN: %check_clang_tidy -check-suffix=DISABLED %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
-// RUN: -config='{CheckOptions:
{cppcoreguidelines-narrowing-conversions.WarnOnIntegerNarrowingConversion:
false}}'
+// RUN: bugprone-narrowing-conversions %t -- \
+// RUN: -config='{CheckOptions:
{bugprone-narrowing-conversions.WarnOnIntegerNarrowingConversion: false}}'
void foo(unsigned long long value) {
int a = value;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:11: warning: narrowing conversion
from 'unsigned long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:11: warning: narrowing conversion
from 'unsigned long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
// DISABLED: No warning for integer narrowing conversions when
WarnOnIntegerNarrowingConversion = false.
long long b = value;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:17: warning: narrowing conversion
from 'unsigned long long' to signed type 'long long' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:17: warning: narrowing conversion
from 'unsigned long long' to signed type 'long long' is implementation-defined
[bugprone-narrowing-conversions]
// DISABLED: No warning for integer narrowing conversions when
WarnOnIntegerNarrowingConversion = false.
}
void
casting_float_to_bool_is_still_operational_when_integer_narrowing_is_disabled(float
f) {
if (f) {
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'float' to 'bool' [cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES-DISABLED: :[[@LINE-2]]:7: warning: narrowing conversion
from 'float' to 'bool' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:7: warning: narrowing conversion
from 'float' to 'bool' [bugprone-narrowing-conversions]
+ // CHECK-MESSAGES-DISABLED: :[[@LINE-2]]:7: warning: narrowing conversion
from 'float' to 'bool' [bugprone-narrowing-conversions]
}
}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
new file mode 100644
index 00000000000000..704d24dbb973df
--- /dev/null
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
@@ -0,0 +1,19 @@
+// RUN: %check_clang_tidy -check-suffix=DEFAULT %s \
+// RUN: bugprone-narrowing-conversions %t -- \
+// RUN: -config='{CheckOptions:
{bugprone-narrowing-conversions.WarnOnIntegerToFloatingPointNarrowingConversion:
true}}'
+
+// RUN: %check_clang_tidy -check-suffix=DISABLED %s \
+// RUN: bugprone-narrowing-conversions %t -- \
+// RUN: -config='{CheckOptions:
{bugprone-narrowing-conversions.WarnOnIntegerToFloatingPointNarrowingConversion:
false}}'
+
+void foo(unsigned long long value) {
+ double a = value;
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:14: warning: narrowing conversion
from 'unsigned long long' to 'double' [bugprone-narrowing-conversions]
+ // DISABLED: No warning for integer to floating-point narrowing conversions
when WarnOnIntegerToFloatingPointNarrowingConversion = false.
+}
+
+void floating_point_to_integer_is_still_not_ok(double f) {
+ int a = f;
+ // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:11: warning: narrowing conversion
from 'double' to 'int' [bugprone-narrowing-conversions]
+ // CHECK-MESSAGES-DISABLED: :[[@LINE-2]]:11: warning: narrowing conversion
from 'double' to 'int' [bugprone-narrowing-conversions]
+}
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-pedanticmode-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-pedanticmode-option.cpp
similarity index 52%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-pedanticmode-option.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-pedanticmode-option.cpp
index eb1a5a67ee1183..d2e2eada96c4b9 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-pedanticmode-option.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-pedanticmode-option.cpp
@@ -1,22 +1,22 @@
-// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: %check_clang_tidy %s bugprone-narrowing-conversions %t \
// RUN: -config="{CheckOptions: { \
-// RUN: cppcoreguidelines-narrowing-conversions.PedanticMode: true}}" \
+// RUN: bugprone-narrowing-conversions.PedanticMode: true}}" \
// RUN: -- -target x86_64-unknown-linux -fsigned-char
namespace floats {
void triggers_wrong_constant_type_warning(double d) {
int i = 0.0;
- // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: constant value should be of
type of type 'int' instead of 'double' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: constant value should be of
type of type 'int' instead of 'double' [bugprone-narrowing-conversions]
i += 2.0;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: constant value should be of type
of type 'int' instead of 'double' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: constant value should be of type
of type 'int' instead of 'double' [bugprone-narrowing-conversions]
i += 2.0f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: constant value should be of type
of type 'int' instead of 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: constant value should be of type
of type 'int' instead of 'float' [bugprone-narrowing-conversions]
}
void triggers_narrowing_warning_when_overflowing() {
unsigned short us = 65537.0;
- // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: narrowing conversion from
constant 'double' to 'unsigned short' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: narrowing conversion from
constant 'double' to 'unsigned short' [bugprone-narrowing-conversions]
}
} // namespace floats
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-unsigned-char.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-unsigned-char.cpp
similarity index 80%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-unsigned-char.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-unsigned-char.cpp
index 6bd437f98d44c5..6a544b46b65d08 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-unsigned-char.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions-unsigned-char.cpp
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: %check_clang_tidy %s bugprone-narrowing-conversions %t \
// RUN: -- -- -target x86_64-unknown-linux -funsigned-char
void narrow_integer_to_unsigned_integer_is_ok() {
@@ -42,24 +42,24 @@ void narrow_integer_to_signed_integer_is_not_ok() {
sc = sc;
sc = s;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'short' to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'short' to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = i;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'int'
to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'int'
to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = l;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'long'
to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'long'
to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = ll;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'long
long' to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'long
long' to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = c;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'char'
to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from 'char'
to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = us;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned short' to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned short' to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = ui;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned int' to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned int' to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = ul;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long' to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long' to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
sc = ull;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long long' to signed type 'signed char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long long' to signed type 'signed char' is implementation-defined
[bugprone-narrowing-conversions]
}
void narrow_constant_to_unsigned_integer_is_ok() {
@@ -72,7 +72,7 @@ void narrow_constant_to_unsigned_integer_is_ok() {
unsigned char uc3 = -1; // unsigned dst type is well defined.
unsigned char uc4 = 256; // unsigned dst type is well defined.
signed char sc = 128;
- // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: narrowing conversion from
constant value 128 (0x00000080) of type 'int' to signed type 'signed char' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: narrowing conversion from
constant value 128 (0x00000080) of type 'int' to signed type 'signed char' is
implementation-defined [bugprone-narrowing-conversions]
}
void narrow_conditional_operator_contant_to_unsigned_is_ok(bool b) {
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions.cpp
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions.cpp
similarity index 77%
rename from
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions.cpp
rename to
clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions.cpp
index 29b38e74e1a22d..39875264bd1e64 100644
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions.cpp
+++
b/clang-tools-extra/test/clang-tidy/checkers/bugprone/narrowing-conversions.cpp
@@ -1,6 +1,6 @@
-// RUN: %check_clang_tidy %s cppcoreguidelines-narrowing-conversions %t \
+// RUN: %check_clang_tidy %s bugprone-narrowing-conversions %t \
// RUN: -config="{CheckOptions: { \
-// RUN:
cppcoreguidelines-narrowing-conversions.WarnOnFloatingPointNarrowingConversion:
false}}" \
+// RUN:
bugprone-narrowing-conversions.WarnOnFloatingPointNarrowingConversion: false}}"
\
// RUN: -- -target x86_64-unknown-linux -fsigned-char
float ceil(float);
@@ -20,27 +20,27 @@ float operator"" _float(unsigned long long);
void narrow_fp_to_int_not_ok(double d) {
int i = 0;
i = d;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'double' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'double' to 'int' [bugprone-narrowing-conversions]
i = 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i = static_cast<float>(d);
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'int' [bugprone-narrowing-conversions]
i = ConvertsToFloat();
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'int' [bugprone-narrowing-conversions]
i = 15_float;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'int' [bugprone-narrowing-conversions]
i += d;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'double' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'double' to 'int' [bugprone-narrowing-conversions]
i += 0.5;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [bugprone-narrowing-conversions]
i += 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i *= 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i /= 0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'float' to 'int' [bugprone-narrowing-conversions]
i += (double)0.5f;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
constant 'double' to 'int' [bugprone-narrowing-conversions]
i += 2.0;
i += 2.0f;
}
@@ -84,29 +84,29 @@ void narrow_double_to_float_not_ok_binary_ops(double d) {
void narrow_fp_constant_to_bool_not_ok() {
bool b1 = 1.0;
- // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant 'double' to 'bool' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant 'double' to 'bool' [bugprone-narrowing-conversions]
bool b2 = 1.0f;
- // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant 'float' to 'bool' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant 'float' to 'bool' [bugprone-narrowing-conversions]
}
void narrow_integer_to_floating() {
{
long long ll; // 64 bits
float f = ll; // doesn't fit in 24 bits
- // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: narrowing conversion from
'long long' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: narrowing conversion from
'long long' to 'float' [bugprone-narrowing-conversions]
double d = ll; // doesn't fit in 53 bits.
- // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: narrowing conversion from
'long long' to 'double' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: narrowing conversion from
'long long' to 'double' [bugprone-narrowing-conversions]
}
{
int i; // 32 bits
float f = i; // doesn't fit in 24 bits
- // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: narrowing conversion from
'int' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: narrowing conversion from
'int' to 'float' [bugprone-narrowing-conversions]
double d = i; // fits in 53 bits.
}
{
short n1, n2;
float f = n1 + n2; // 'n1 + n2' is of type 'int' because of integer rules
- // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: narrowing conversion from
'int' to 'float' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:15: warning: narrowing conversion from
'int' to 'float' [bugprone-narrowing-conversions]
}
{
short s; // 16 bits
@@ -156,41 +156,41 @@ void narrow_integer_to_signed_integer_is_not_ok() {
c = c;
c = s;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'short' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'short' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
c = i;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'int'
to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'int'
to signed type 'char' is implementation-defined [bugprone-narrowing-conversions]
c = l;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long'
to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long'
to signed type 'char' is implementation-defined [bugprone-narrowing-conversions]
c = ll;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long
long' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long
long' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
c = uc;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned char' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned char' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
c = us;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned short' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned short' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
c = ui;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned int' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned int' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
c = ul;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
c = ull;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long long' to signed type 'char' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long long' to signed type 'char' is implementation-defined
[bugprone-narrowing-conversions]
i = c;
i = s;
i = i;
i = l;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long'
to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long'
to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
i = ll;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long
long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from 'long
long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
i = uc;
i = us;
i = ui;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned int' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned int' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
i = ul;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
i = ull;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long long' to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'unsigned long long' to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
ll = c;
ll = s;
@@ -202,9 +202,9 @@ void narrow_integer_to_signed_integer_is_not_ok() {
ll = us;
ll = ui;
ll = ul;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long' to signed type 'long long' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long' to signed type 'long long' is implementation-defined
[bugprone-narrowing-conversions]
ll = ull;
- // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long long' to signed type 'long long' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: narrowing conversion from
'unsigned long long' to signed type 'long long' is implementation-defined
[bugprone-narrowing-conversions]
}
void narrow_constant_to_unsigned_integer_is_ok() {
@@ -222,16 +222,16 @@ void narrow_constant_to_signed_integer_is_not_ok() {
char c1 = -128;
char c2 = 127;
char c3 = -129;
- // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant value -129 (0xFFFFFF7F) of type 'int' to signed type 'char' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant value -129 (0xFFFFFF7F) of type 'int' to signed type 'char' is
implementation-defined [bugprone-narrowing-conversions]
char c4 = 128;
- // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant value 128 (0x00000080) of type 'int' to signed type 'char' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: narrowing conversion from
constant value 128 (0x00000080) of type 'int' to signed type 'char' is
implementation-defined [bugprone-narrowing-conversions]
short s1 = -32768;
short s2 = 32767;
short s3 = -32769;
- // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: narrowing conversion from
constant value -32769 (0xFFFF7FFF) of type 'int' to signed type 'short' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: narrowing conversion from
constant value -32769 (0xFFFF7FFF) of type 'int' to signed type 'short' is
implementation-defined [bugprone-narrowing-conversions]
short s4 = 32768;
- // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: narrowing conversion from
constant value 32768 (0x00008000) of type 'int' to signed type 'short' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: narrowing conversion from
constant value 32768 (0x00008000) of type 'int' to signed type 'short' is
implementation-defined [bugprone-narrowing-conversions]
}
void narrow_conditional_operator_contant_to_unsigned_is_ok(bool b) {
@@ -244,22 +244,22 @@ void
narrow_conditional_operator_contant_to_unsigned_is_ok(bool b) {
void narrow_conditional_operator_contant_to_signed_is_not_ok(bool b) {
char uc1 = b ? 1 : 0;
char uc2 = b ? 1 : 128;
- // CHECK-MESSAGES: :[[@LINE-1]]:22: warning: narrowing conversion from
constant value 128 (0x00000080) of type 'int' to signed type 'char' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:22: warning: narrowing conversion from
constant value 128 (0x00000080) of type 'int' to signed type 'char' is
implementation-defined [bugprone-narrowing-conversions]
char uc3 = b ? -129 : 0;
- // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: narrowing conversion from
constant value -129 (0xFFFFFF7F) of type 'int' to signed type 'char' is
implementation-defined [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: narrowing conversion from
constant value -129 (0xFFFFFF7F) of type 'int' to signed type 'char' is
implementation-defined [bugprone-narrowing-conversions]
unsigned long long ysize;
long long mirror = b ? -1 : ysize - 1;
- // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: narrowing conversion from
constant value 18446744073709551615 (0xFFFFFFFFFFFFFFFF) of type 'unsigned long
long' to signed type 'long long' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES: :[[@LINE-2]]:37: warning: narrowing conversion from
'unsigned long long' to signed type 'long long' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:26: warning: narrowing conversion from
constant value 18446744073709551615 (0xFFFFFFFFFFFFFFFF) of type 'unsigned long
long' to signed type 'long long' is implementation-defined
[bugprone-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-2]]:37: warning: narrowing conversion from
'unsigned long long' to signed type 'long long' is implementation-defined
[bugprone-narrowing-conversions]
}
void narrow_constant_to_floating_point() {
float f_ok = 1ULL << 24; // fits in 24 bits mantissa.
float f_not_ok = (1ULL << 24) + 1ULL; // doesn't fit in 24 bits mantissa.
- // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: narrowing conversion from
constant value 16777217 of type 'unsigned long long' to 'float'
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: narrowing conversion from
constant value 16777217 of type 'unsigned long long' to 'float'
[bugprone-narrowing-conversions]
double d_ok = 1ULL << 53; // fits in 53 bits mantissa.
double d_not_ok = (1ULL << 53) + 1ULL; // doesn't fit in 53 bits mantissa.
- // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: narrowing conversion from
constant value 9007199254740993 of type 'unsigned long long' to 'double'
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: narrowing conversion from
constant value 9007199254740993 of type 'unsigned long long' to 'double'
[bugprone-narrowing-conversions]
}
void casting_integer_to_bool_is_ok() {
@@ -275,13 +275,13 @@ void casting_integer_to_bool_is_ok() {
void casting_float_to_bool_is_not_ok() {
float f;
while (f) {
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: narrowing conversion from
'float' to 'bool' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: narrowing conversion from
'float' to 'bool' [bugprone-narrowing-conversions]
}
for (; f;) {
- // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: narrowing conversion from
'float' to 'bool' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: narrowing conversion from
'float' to 'bool' [bugprone-narrowing-conversions]
}
if (f) {
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'bool' [cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'float' to 'bool' [bugprone-narrowing-conversions]
}
}
@@ -352,7 +352,7 @@ void typedef_context() {
i64 = i; // Okay, no narrowing.
i = i64;
- // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'myint64_t' (aka 'long long') to signed type 'int' is implementation-defined
[cppcoreguidelines-narrowing-conversions]
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: narrowing conversion from
'myint64_t' (aka 'long long') to signed type 'int' is implementation-defined
[bugprone-narrowing-conversions]
}
} // namespace floats
diff --git
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
deleted file mode 100644
index 35ca61b6a9a8c5..00000000000000
---
a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/narrowing-conversions-narrowingintegertofloatingpoint-option.cpp
+++ /dev/null
@@ -1,19 +0,0 @@
-// RUN: %check_clang_tidy -check-suffix=DEFAULT %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
-// RUN: -config='{CheckOptions:
{cppcoreguidelines-narrowing-conversions.WarnOnIntegerToFloatingPointNarrowingConversion:
true}}'
-
-// RUN: %check_clang_tidy -check-suffix=DISABLED %s \
-// RUN: cppcoreguidelines-narrowing-conversions %t -- \
-// RUN: -config='{CheckOptions:
{cppcoreguidelines-narrowing-conversions.WarnOnIntegerToFloatingPointNarrowingConversion:
false}}'
-
-void foo(unsigned long long value) {
- double a = value;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:14: warning: narrowing conversion
from 'unsigned long long' to 'double' [cppcoreguidelines-narrowing-conversions]
- // DISABLED: No warning for integer to floating-point narrowing conversions
when WarnOnIntegerToFloatingPointNarrowingConversion = false.
-}
-
-void floating_point_to_integer_is_still_not_ok(double f) {
- int a = f;
- // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:11: warning: narrowing conversion
from 'double' to 'int' [cppcoreguidelines-narrowing-conversions]
- // CHECK-MESSAGES-DISABLED: :[[@LINE-2]]:11: warning: narrowing conversion
from 'double' to 'int' [cppcoreguidelines-narrowing-conversions]
-}
>From 2003efa9a2acb97becdf34ec92d586b114e13e6a Mon Sep 17 00:00:00 2001
From: Congcong Cai <congcongcai0...@163.com>
Date: Wed, 18 Dec 2024 23:09:29 +0800
Subject: [PATCH 2/3] format, swap alias table
---
clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp | 2 +-
.../clang-tidy/bugprone/NarrowingConversionsCheck.cpp | 2 +-
.../clang-tidy/bugprone/NarrowingConversionsCheck.h | 2 +-
.../cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp | 2 +-
clang-tools-extra/docs/clang-tidy/checks/list.rst | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
index c55acf0f4e1803..b27616f3dcc658 100644
--- a/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
@@ -16,7 +16,6 @@
#include "BitwisePointerCastCheck.h"
#include "BoolPointerImplicitConversionCheck.h"
#include "BranchCloneCheck.h"
-#include "NarrowingConversionsCheck.h"
#include "CastingThroughVoidCheck.h"
#include "ChainedComparisonCheck.h"
#include "ComparePointerToMemberVirtualFunctionCheck.h"
@@ -47,6 +46,7 @@
#include "MultiLevelImplicitPointerConversionCheck.h"
#include "MultipleNewInOneExpressionCheck.h"
#include "MultipleStatementMacroCheck.h"
+#include "NarrowingConversionsCheck.h"
#include "NoEscapeCheck.h"
#include "NonZeroEnumToBoolConversionCheck.h"
#include "NondeterministicPointerIterationOrderCheck.h"
diff --git
a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
index 7c9903c20ac6a6..a950704208c73b 100644
--- a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.cpp
@@ -614,4 +614,4 @@ void NarrowingConversionsCheck::check(const
MatchFinder::MatchResult &Result) {
return handleImplicitCast(*Result.Context, *Cast);
llvm_unreachable("must be binary operator or cast expression");
}
-} // namespace clang::tidy::cppcoreguidelines
+} // namespace clang::tidy::bugprone
diff --git a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
index eb7b920c1aff63..87348c924b1ec4 100644
--- a/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
+++ b/clang-tools-extra/clang-tidy/bugprone/NarrowingConversionsCheck.h
@@ -104,6 +104,6 @@ class NarrowingConversionsCheck : public ClangTidyCheck {
const bool PedanticMode;
};
-} // namespace clang::tidy::cppcoreguidelines
+} // namespace clang::tidy::bugprone
#endif //
LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CPPCOREGUIDELINES_NARROWING_CONVERSIONS_H
diff --git
a/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
b/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
index 4dded38482e688..6adef04264347b 100644
---
a/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
+++
b/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
@@ -9,6 +9,7 @@
#include "../ClangTidy.h"
#include "../ClangTidyModule.h"
#include "../ClangTidyModuleRegistry.h"
+#include "../bugprone/NarrowingConversionsCheck.h"
#include "../misc/NonPrivateMemberVariablesInClassesCheck.h"
#include "../misc/UnconventionalAssignOperatorCheck.h"
#include "../modernize/AvoidCArraysCheck.h"
@@ -30,7 +31,6 @@
#include "MacroUsageCheck.h"
#include "MisleadingCaptureDefaultByValueCheck.h"
#include "MissingStdForwardCheck.h"
-#include "../bugprone/NarrowingConversionsCheck.h"
#include "NoMallocCheck.h"
#include "NoSuspendWithLockCheck.h"
#include "OwningMemoryCheck.h"
diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst
b/clang-tools-extra/docs/clang-tidy/checks/list.rst
index 4d8853a0f6d86c..95a88805e55fe0 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -411,7 +411,7 @@ Check aliases
.. csv-table::
:header: "Name", "Redirect", "Offers fixes"
- :doc:`bugprone-narrowing-conversions <bugprone/narrowing-conversions>`,
:doc:`cppcoreguidelines-narrowing-conversions
<cppcoreguidelines/narrowing-conversions>`,
+ :doc:`cppcoreguidelines-narrowing-conversions
<bugprone/narrowing-conversions>`, :doc:`bugprone-narrowing-conversions
<cppcoreguidelines/narrowing-conversions>`,
:doc:`cert-arr39-c <cert/arr39-c>`, :doc:`bugprone-sizeof-expression
<bugprone/sizeof-expression>`,
:doc:`cert-con36-c <cert/con36-c>`,
:doc:`bugprone-spuriously-wake-up-functions
<bugprone/spuriously-wake-up-functions>`,
:doc:`cert-con54-cpp <cert/con54-cpp>`,
:doc:`bugprone-spuriously-wake-up-functions
<bugprone/spuriously-wake-up-functions>`,
>From 593fa9cceaf50e9a370f2bcad299603b7d7a71e8 Mon Sep 17 00:00:00 2001
From: Congcong Cai <congcongcai0...@163.com>
Date: Fri, 20 Dec 2024 08:10:48 +0800
Subject: [PATCH 3/3] add release note
---
clang-tools-extra/docs/ReleaseNotes.rst | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst
b/clang-tools-extra/docs/ReleaseNotes.rst
index 3fd7a4f9da18ad..aa2a76554241d0 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -356,6 +356,13 @@ Removed checks
Miscellaneous
^^^^^^^^^^^^^
+- The :doc:`bugprone-narrowing-conversions
<clang-tidy/checks/bugprone/narrowing-conversions>`
+ check is no longer an alias of :doc:`cppcoreguidelines-narrowing-conversions
+ <clang-tidy/checks/cppcoreguidelines/narrowing-conversions>`. Instead,
+ :doc:`cppcoreguidelines-narrowing-conversions
+ <clang-tidy/checks/cppcoreguidelines/narrowing-conversions>` is now an alias
+ of :doc:`bugprone-narrowing-conversions
<clang-tidy/checks/bugprone/narrowing-conversions>`.
+
Improvements to include-fixer
-----------------------------
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
