mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: CMakeLists.txt:416 +set(LIBCXXABI_HAS_UNDEFINED_SYMBOLS ((NOT LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS) + OR (LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY AND LIBCXXABI_ENABLE_SHARED))) + ---------------- It is unrelated to this change, but I'm wondering about the `LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY` condition. I see undefined reference to libc symbols. That said we're linking to libSystem which provided everything, so I'm not even sure why `dynamic_lookup` is needed at all? https://reviews.llvm.org/D30517 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
