https://github.com/kiranchandramohan approved this pull request.

LG. Thanks.

Just a comment, no action required. I see some hits for realloc-lhs in the 
gfortran testsuite. Will some of these tests start behaving differently?

```
CMakeLists.txt:  -fno-realloc-lhs
CMakeLists.txt:  -Wrealloc-lhs
CMakeLists.txt:  -Wrealloc-lhs-all
regression/inline_matmul_13.f90:! { dg-options "-ffrontend-optimize 
-fdump-tree-original -Wrealloc-lhs" }
regression/tests.cmake:compile;realloc_on_assign_14.f90;;-Wrealloc-lhs-all 
-Wrealloc-lhs;;
regression/tests.cmake:compile;realloc_on_assign_21.f90;xfail;-fno-realloc-lhs;;
regression/tests.cmake:run;cshift_bounds_2.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/tests.cmake:run;inline_matmul_1.f90;;-ffrontend-optimize 
-fdump-tree-optimized -Wrealloc-lhs;;
regression/tests.cmake:run;inline_matmul_13.f90;;-ffrontend-optimize 
-fdump-tree-original -Wrealloc-lhs;;
regression/tests.cmake:run;inline_matmul_16.f90;;-ffrontend-optimize 
-fdump-tree-optimized -Wrealloc-lhs -finline-matmul-limit=1000 -O;;
regression/tests.cmake:run;inline_matmul_20.f90;;-fno-realloc-lhs 
-ffrontend-optimize;;
regression/tests.cmake:run;matmul_bounds_10.f90;xfail;-fno-backtrace 
-fbounds-check -fno-realloc-lhs;;
regression/tests.cmake:run;matmul_bounds_14.f 
blas_gemm_routines.f;xfail;-fno-realloc-lhs -fdump-tree-optimized 
-fcheck=bounds -fblas-matmul-limit=1 -O -fexternal-blas;;
regression/tests.cmake:run;matmul_bounds_2.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/tests.cmake:run;matmul_bounds_3.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/tests.cmake:run;matmul_bounds_4.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/tests.cmake:run;matmul_bounds_5.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/tests.cmake:run;matmul_bounds_8.f90;xfail;-fno-backtrace 
-fbounds-check -fno-realloc-lhs;;
regression/tests.cmake:run;transpose_2.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/tests.cmake:run;unpack_bounds_1.f90;xfail;-fbounds-check 
-fno-realloc-lhs;;
regression/matmul_bounds_3.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" 
}
regression/realloc_on_assign_14.f90:! { dg-options "-Wrealloc-lhs-all 
-Wrealloc-lhs" }
regression/realloc_on_assign_21.f90:! { dg-options "-fno-realloc-lhs" }
regression/realloc_on_assign_21.f90:var = t() ! { dg-error "Assignment to an 
allocatable polymorphic variable at .1. requires '-frealloc-lhs'" }
regression/matmul_bounds_5.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" 
}
regression/matmul_bounds_14.f:C { dg-options "-fno-realloc-lhs 
-fdump-tree-optimized -fcheck=bounds -fblas-matmul-limit=1 -O -fexternal-blas" }
regression/matmul_bounds_10.f90:! { dg-options "-fno-backtrace -fbounds-check 
-fno-realloc-lhs" }
regression/transpose_2.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" }
regression/matmul_bounds_2.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" 
}
regression/matmul_bounds_8.f90:! { dg-options "-fno-backtrace -fbounds-check 
-fno-realloc-lhs" }
regression/cshift_bounds_2.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" 
}
regression/DisabledFiles.cmake:  # Require -fno-realloc-lhs or similar.
regression/unpack_bounds_1.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" 
}
regression/inline_matmul_1.f90:! { dg-options "-ffrontend-optimize 
-fdump-tree-optimized -Wrealloc-lhs" }
regression/matmul_bounds_4.f90:! { dg-options "-fbounds-check -fno-realloc-lhs" 
}
regression/inline_matmul_20.f90:! { dg-additional-options "-fno-realloc-lhs 
-ffrontend-optimize" }
regression/inline_matmul_16.f90:! { dg-options "-ffrontend-optimize 
-fdump-tree-optimized -Wrealloc-lhs -finline-matmul-limit=1000 -O" }
```

https://github.com/llvm/llvm-project/pull/120165
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to