https://github.com/GeorgeKA updated https://github.com/llvm/llvm-project/pull/118360
>From 3856d6ccf8b10f85cee8d03a349eb768600bd0e0 Mon Sep 17 00:00:00 2001 From: GeorgeKA <k._asa...@hotmail.com> Date: Mon, 2 Dec 2024 13:34:22 -0500 Subject: [PATCH 1/2] [clang] Document the return value of __builtin_COLUMN PR for issue #78657 Updated clang/docs/LanguageExtensions.rst to detail the return value of __builtin_COLUMN for this implementation. --- clang/docs/LanguageExtensions.rst | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/clang/docs/LanguageExtensions.rst b/clang/docs/LanguageExtensions.rst index 3c9078bcdf8118..00466fd2e7f020 100644 --- a/clang/docs/LanguageExtensions.rst +++ b/clang/docs/LanguageExtensions.rst @@ -4514,9 +4514,13 @@ default member initializer, the invocation point is the location of the constructor or aggregate initialization used to create the object. Otherwise the invocation point is the same as the location of the builtin. -When the invocation point of ``__builtin_FUNCTION`` is not a function scope the +When the invocation point of ``__builtin_FUNCTION`` is not a function scope, the empty string is returned. +The builtin ``__builtin_COLUMN`` returns the offset from the start of the line, +beginning from column 1. `This may differ from other implementations. +<https://en.cppreference.com/w/cpp/utility/source_location/column>`_ + The builtin ``__builtin_source_location`` returns a pointer to constant static data of type ``std::source_location::__impl``. This type must have already been defined, and must contain exactly four fields: ``const char *_M_file_name``, >From 2f132e121fb5e4d306bcfe89301e121bdf3b9544 Mon Sep 17 00:00:00 2001 From: GeorgeKA <k._asa...@hotmail.com> Date: Tue, 10 Dec 2024 11:26:41 -0500 Subject: [PATCH 2/2] Updated the documentation link to the standard instead of cppreference --- clang/docs/LanguageExtensions.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/docs/LanguageExtensions.rst b/clang/docs/LanguageExtensions.rst index 00466fd2e7f020..33e7f983063b1a 100644 --- a/clang/docs/LanguageExtensions.rst +++ b/clang/docs/LanguageExtensions.rst @@ -4519,7 +4519,7 @@ empty string is returned. The builtin ``__builtin_COLUMN`` returns the offset from the start of the line, beginning from column 1. `This may differ from other implementations. -<https://en.cppreference.com/w/cpp/utility/source_location/column>`_ +<https://eel.is/c++draft/support.srcloc#tab:support.srcloc.current-row-3-column-2-sentence-2>`_ The builtin ``__builtin_source_location`` returns a pointer to constant static data of type ``std::source_location::__impl``. This type must have already been _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
