================ @@ -793,20 +793,23 @@ void ARMTargetELFStreamer::switchVendor(StringRef Vendor) { void ARMTargetELFStreamer::emitAttribute(unsigned Attribute, unsigned Value) { getStreamer().setAttributeItem(Attribute, Value, - /* OverwriteExisting= */ true); + /* OverwriteExisting= */ true, + getStreamer().Contents); ---------------- sivan-shani wrote:
On one hand the API has indeed changed, on the other it remove the need to add more function to the base class and make the function more versatile. Personally I like this new design because it explicitly show which data structure is being populated with the new attribute. Not too attached to this design, if you are not convinced I'll add a new function. https://github.com/llvm/llvm-project/pull/118771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits