dlj added a comment.

In https://reviews.llvm.org/D30372#686871, @ahatanak wrote:

> Have you considered using "include_directories" in CMakeLists.txt to avoid 
> including "../Something.h"?


I don't want to take that approach, and there's a specific reason why: my 
concern isn't with three extra bytes, it's the fact that the headers are in an 
unusual place. It's typical to include headers from a subdirectory, or from the 
includes directory, but far less common to include from a parent lib directory. 
Hiding that fact seems strictly worse to me.


https://reviews.llvm.org/D30372



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to