Can't you just put gnuwin rm on your bot? Our Windows bots are happy with the test, and having to support an rm without wildcard support seems pretty strange. (Https://is.gd/chromeclang -> tools -> gnuwin-6.zip are the executables our bot uses to run llvm tests)
On Feb 24, 2017 8:13 PM, "Yung, Douglas via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Hi Nico, > > The test you added is causing a failure on the PS4 Windows bot. The root > of the cause is that the Windows version of rm does not accept wildcards > unfortunately. To fix make it work on Windows, you likely need to specify > exactly what files/directories you want to delete without using a wildcard: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/6030: > > $ "rm" "C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4- > windows10pro-fast\llvm.obj\tools\clang\test\Format\Output/*" > # command stderr: > rm: cannot remove `C:\\Buildbot\\Slave\\llvm-clang-lld-x86_64-scei-ps4- > windows10pro-fast\\llvm.obj\\tools\\clang\\test\\Format\\Output/*': > Invalid argument > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/6031: > > $ "rm" "C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4- > windows10pro-fast\llvm.obj\tools\clang\test\Format\Output/inplace*" > # command stderr: > rm: cannot remove `C:\\Buildbot\\Slave\\llvm-clang-lld-x86_64-scei-ps4- > windows10pro-fast\\llvm.obj\\tools\\clang\\test\\Format\\Output/inplace*': > Invalid argument > > Can you fix the test? > > Douglas Yung > > > -----Original Message----- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Nico Weber via cfe-commits > > Sent: Friday, February 24, 2017 13:02 > > To: cfe-commits@lists.llvm.org > > Subject: r296171 - Try to unbreak tests after r296166 > > > > Author: nico > > Date: Fri Feb 24 15:01:43 2017 > > New Revision: 296171 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=296171&view=rev > > Log: > > Try to unbreak tests after r296166 > > > > Looks like %T isn't per-test but per-test-directory, and the rm was > deleting > > temp files written by other tests in test/Format. Limit the rm's scope > a bit. > > > > Modified: > > cfe/trunk/test/Format/inplace.cpp > > > > Modified: cfe/trunk/test/Format/inplace.cpp > > URL: http://llvm.org/viewvc/llvm- > > project/cfe/trunk/test/Format/inplace.cpp?rev=296171&r1= > 296170&r2=296171&view= > > diff > > ============================================================ > ================== > > --- cfe/trunk/test/Format/inplace.cpp (original) > > +++ cfe/trunk/test/Format/inplace.cpp Fri Feb 24 15:01:43 2017 > > @@ -1,6 +1,6 @@ > > // Regression test to check that clang-format does not leave behind > temporary > > // files on Windows when doing in-place formatting. > > -// RUN: rm %T/* > > +// RUN: rm %T/inplace* > > // RUN: cp %s %T/inplace.cpp > > // RUN: clang-format -style=LLVM -i %T/inplace.cpp // RUN: ls %T > > > %T/files.txt > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
